Re: [PATCH] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v4

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Thu, 7 Nov 2013 14:22:55 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Wed, Nov 06, 2013 at 11:25:55AM -0800, Jesse Barnes wrote:
> > Retrieve current framebuffer config info from the regs and create an fb
> > object for the buffer the BIOS or boot loader left us.  This should
> > allow for smooth transitions to userspace apps once we finish the
> > initial configuration construction.
> > 
> > v2: check for non-native modes and adjust (Jesse)
> >     fixup aperture and cmap frees (Imre)
> >     use unlocked unref if init_bios fails (Jesse)
> >     fix curly brace around DSPADDR check (Imre)
> >     comment failure path for pin_and_fence (Imre)
> > v3: fixup fixup of aperture frees (Chris)
> > v4: update to current bits (locking & pin_and_fence hack) (Jesse)
> 
> The only thing that I noticed was that the bookkeeping for the fb/obj is
> incorrect - which is presumably the hack mentioned above.

Yeah I should have left the pin_and_fence in with an #if 0 to make that
clearer... is that the only thing that's missing?

Any thoughts on why the pin_and_fence falls over on the preallocated
object?

-- 
Jesse Barnes, Intel Open Source Technology Center