From: Daniel Vetter <daniel@ffwll.ch>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Make AGP support optional
Date: Fri, 8 Nov 2013 18:37:55 +0100 [thread overview]
Message-ID: <20131108173755.GE14082@phenom.ffwll.local> (raw)
In-Reply-To: <1383652808-25752-1-git-send-email-ville.syrjala@linux.intel.com>
On Tue, Nov 05, 2013 at 02:00:08PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We only depend on the intel-gtt module for GTT frobbign on older gens.
> The intel_agp module is optional, except for UMS and some old XvMC
> userland on gen3. So make AGP support optional. As before, we will
> fail the i915 init for UMS and gen3 KMS the same as before if
> intel_agp isn't around.
>
> intel-gtt.c is left with a somewhat ugly ifdef mess, but I'm going
> to save that for a later cleaning.
>
> At least my gen2 still works with the patch and CONFIG_AGP=n.
>
> v2: Make i915 depend on X86 and PCI, and intel-gtt depend on PCI
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Every nail in the fake agp coffin is a good one.
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-11-08 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 12:00 [PATCH v2] drm/i915: Make AGP support optional ville.syrjala
2013-11-08 17:37 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108173755.GE14082@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox