Re: [PATCH] lib/drmtest: Retire requests via drop caches after gem_quiescent_gpu

[Ben Widawsky <ben@bwidawsk.net>]

On Tue, Nov 05, 2013 at 07:35:16PM +0100, Daniel Vetter wrote:
> On Tue, Nov 05, 2013 at 02:15:19PM +0000, oscar.mateo@intel.com wrote:
> > From: Oscar Mateo <oscar.mateo@intel.com>
> > 
> > This helps make sure that the GPU is really quiescent by getting
> > rid of any residual stuff.
> > 
> > Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
> 
> Merged, thanks for the patch.
> -Daniel

I'm hitting what seems to be a race on gem_suspend. Please fix.
Subtest debugfs-reader: SUCCESS
Test assertion failure function igt_drop_caches_set, file igt_debugfs.c:336:


> 
> > ---
> >  lib/drmtest.c |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/lib/drmtest.c b/lib/drmtest.c
> > index e3fc166..d8fc60f 100644
> > --- a/lib/drmtest.c
> > +++ b/lib/drmtest.c
> > @@ -47,6 +47,7 @@
> >  #include "i915_drm.h"
> >  #include "intel_chipset.h"
> >  #include "intel_gpu_tools.h"
> > +#include "igt_debugfs.h"
> >  
> >  /* This file contains a bunch of wrapper functions to directly use gem ioctls.
> >   * Mostly useful to write kernel tests. */
> > @@ -163,6 +164,7 @@ void gem_quiescent_gpu(int fd)
> >  	}
> >  
> >  	gem_sync(fd, handle);
> > +	igt_drop_caches_set(DROP_RETIRE);
> >  }
> >  
> >  /**
> > -- 
> > 1.7.9.5
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ben Widawsky, Intel Open Source Technology Center