public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 19/23] piglit: Update the README file with the new way of running tests
Date: Fri, 15 Nov 2013 18:16:08 +0100	[thread overview]
Message-ID: <20131115171608.GX22741@phenom.ffwll.local> (raw)
In-Reply-To: <1384533220-20780-20-git-send-email-damien.lespiau@intel.com>

On Fri, Nov 15, 2013 at 04:33:36PM +0000, Damien Lespiau wrote:
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Hm, I'd keep the references to the real piglit somewhere, since our copy
here is just for convenience. Development should happen upstream.
-Daniel

> ---
>  README | 54 ++++++++++++++++++++++++++++++++----------------------
>  1 file changed, 32 insertions(+), 22 deletions(-)
> 
> diff --git a/README b/README
> index 246e24c..021888f 100644
> --- a/README
> +++ b/README
> @@ -24,38 +24,48 @@ tests/
>  	changes.  Hopefully this can cover the relevant cases we need to
>  	worry about, including backwards compatibility.
>  
> -	Note: The old automake based testrunner had to be scraped due to
> -	upstream changes which broke dynamic creation of the test list. Of
> -	course it is still possible to directly run tests, even when not always
> -	limiting tests to specific subtests (like piglit does).
> +	After having compiled the tests, one can run the test-suite with:
>  
> -	The more comfortable way to run tests is with piglit. First grab piglit
> -	from:
> +	$ sudo make run-tests
>  
> -	git://anongit.freedesktop.org/piglit
> +	As we have display tests, we need to be DRM master. As a result the
> +	test suite can only be run if no other DRM client is active.
> +	Similarly, some tests access debugfs, so we need to be root.
>  
> -	and build it (no need to install anything). Then we need to link up the
> -	i-g-t sources with piglit
> +	"make run-tests" create a $date-piglit-results.$n directory with the
> +	results of the run. More specifically:
> +	  - $date-piglit-results.$n/main JSON file with the test results
> +	  - $date-piglit-results.$n/html/index.html HTML summary of the run
>  
> -	piglit-sources $ cd bin
> -	piglit-sources/bin $ ln $i-g-t-sources igt -s
> +	Where $date is the date formated with `date +%Y%m%d` and $n the nth run
> +	of the day.
>  
> -	The tests in the i-g-t sources need to have been built already. Then we
> -	can run the testcases with (as usual as root, no other drm clients
> -	running):
> +	PIGLIT_FLAGS can be used to give options to the underlying piglit
> +	runner. For instance, to exclude test matching '^kms_':
>  
> -	piglit-sources # ./piglit-run.py tests/igt.tests <results-file>
> +	$ sudo make run-tests PIGLIT_FLAGS="-x ^kms_"
>  
> -	The testlist is built at runtime, so no need to update anything in
> -	piglit when adding new tests. See
> +	For the list of piglit options, run:
>  
> -	piglit-sources $ ./piglit-run.py -h
> +	$ ./piglit/piglit-run.py -h
>  
> -	for some useful options.
> +	Another useful feature is to be able to resume an interrupted run. To
> +	do that, make run-tests needs to know which run we are talking about:
>  
> -	Piglit only runs a default set of tests and is useful for regression
> -	testing. Other tests not run are:
> -	- tests that might hang the gpu, see HANG in Makefile.am
> +	$ sudo make run-tests RESUME=$date-piglit-results.$n
> +
> +	or, more succinctly:
> +
> +	$ sudo make run-tests R=$date-piglit-results.$n
> +
> +	It's possible to combine PIGLIT_FLAGS and RESUME. This is useful to
> +	resume runs where a specific test deterministically hang the machine:
> +
> +	$ sudo make run-tests PIGLIT_FLAGS="-x drv_module_reload" R=$date-piglit-results.$n
> +
> +	"make run-tests" only runs a default set of tests and is useful for
> +	regression testing. Other tests not run are:
> +	- tests that might hang the gpu, see HANG in tests/Makefile.sources
>  	- gem_stress, a stress test suite. Look at the source for all the
>  	  various options.
>  	- testdisplay is only run in the default mode. testdisplay has tons of
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2013-11-15 17:15 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15 16:33 [igt] Making the test-suite easier to run Damien Lespiau
2013-11-15 16:33 ` [PATCH 01/23] piglit: Add a script to synchronise the piglit test runner Damien Lespiau
2013-11-15 16:33 ` [PATCH 02/23] piglit: Import piglit Damien Lespiau
2013-11-15 16:33 ` [PATCH 03/23] piglit: Import igt.tests from piglit Damien Lespiau
2013-11-15 16:33 ` [PATCH 04/23] piglit: Adapt igt.tests to discover the tests directory itself Damien Lespiau
2013-11-15 16:33 ` [PATCH 05/23] piglit: Add a 'run-tests' Makefile target Damien Lespiau
2013-11-15 16:33 ` [PATCH 06/23] piglit: Add the option to inject piglit arguments Damien Lespiau
2013-11-15 16:33 ` [PATCH 07/23] piglit: Support resuming from a previous run Damien Lespiau
2013-11-15 16:33 ` [PATCH 08/23] piglit: Merge filters from previous invocations when resuming Damien Lespiau
2013-11-15 16:33 ` [PATCH 09/23] piglit: Fix resuming of previous runs Damien Lespiau
2013-11-15 16:33 ` [PATCH 10/23] piglit: Run our test suite with --no-concurrency Damien Lespiau
2013-11-15 17:08   ` Daniel Vetter
2013-11-15 17:17     ` Damien Lespiau
2013-11-15 16:33 ` [PATCH 11/23] piglit: Generate a Makefile.am from the sync script Damien Lespiau
2013-11-15 16:33 ` [PATCH 12/23] piglit: Always write the HTML test results Damien Lespiau
2013-11-15 16:33 ` [PATCH 13/23] piglit: Add a hint that there's an HTML summary Damien Lespiau
2013-11-15 16:33 ` [PATCH 14/23] framework: Humanize time values in the HTML report Damien Lespiau
2013-11-15 16:33 ` [PATCH 15/23] piglit: Support R= as RESUME= for the lazies Damien Lespiau
2013-11-15 16:33 ` [PATCH 16/23] drm_lib.sh: Tune the DRM master message a bit Damien Lespiau
2013-11-15 17:13   ` Daniel Vetter
2013-11-15 17:17     ` Damien Lespiau
2013-11-15 16:33 ` [PATCH 17/23] piglit: Make sure there's no DRM master before launching the tests Damien Lespiau
2013-11-15 16:33 ` [PATCH 18/23] piglit: Make sure we are running the tests as root Damien Lespiau
2013-11-15 16:33 ` [PATCH 19/23] piglit: Update the README file with the new way of running tests Damien Lespiau
2013-11-15 17:16   ` Daniel Vetter [this message]
2013-11-15 17:21     ` Damien Lespiau
2013-11-15 16:33 ` [PATCH 20/23] framework: Dump the result of 'uname -a' in the report Damien Lespiau
2013-11-15 16:33 ` [PATCH 21/23] lib: Introduce igt_run_quick() Damien Lespiau
2013-11-15 16:33 ` [PATCH 22/23] lib: Change SLOW_QUICK() to use igt_run_quick() Damien Lespiau
2013-11-15 16:33 ` [PATCH 23/23] pm_pc8: Use SLOW_QUICK() with the number of rounds Damien Lespiau
2013-11-15 17:20 ` [igt] Making the test-suite easier to run Damien Lespiau
2013-11-15 17:23 ` Daniel Vetter
2013-11-15 17:33   ` Mateo Lozano, Oscar
2013-11-15 17:41   ` Damien Lespiau
2013-11-15 19:27     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131115171608.GX22741@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox