From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 10/23] piglit: Run our test suite with --no-concurrency
Date: Fri, 15 Nov 2013 18:08:27 +0100 [thread overview]
Message-ID: <20131115170827.GV22741@phenom.ffwll.local> (raw)
In-Reply-To: <1384533220-20780-11-git-send-email-damien.lespiau@intel.com>
On Fri, Nov 15, 2013 at 04:33:27PM +0000, Damien Lespiau wrote:
> Tests tend to assume they are the only thing running, some need DRM
> master, some fill the memory. All in all, they are some correctness
> issues if we run tests concurrently.
>
> Acked-by: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Concurrency is a per-test opt-in thing in piglit. So this is cargo-cult
and worse will prevent us to run a subset of tests to run in parallel
(e.g. once we have a naming scheme for abi stuff).
-Daniel
> ---
> Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 5742b82..f280879 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -50,7 +50,7 @@ dist-hook: ChangeLog INSTALL
> #
> # Useful shortcuts to run tests
> #
> -PIGLIT := $(srcdir)/piglit/piglit-run.py
> +PIGLIT := $(srcdir)/piglit/piglit-run.py --no-concurrency
> PIGLIT_SUMMARY := $(srcdir)/piglit/piglit-summary.py -s
> PIGLIT_HTML := $(srcdir)/piglit/piglit-summary-html.py
> IGT_TESTS := $(abs_srcdir)/piglit/tests/igt.tests
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-11-15 17:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 16:33 [igt] Making the test-suite easier to run Damien Lespiau
2013-11-15 16:33 ` [PATCH 01/23] piglit: Add a script to synchronise the piglit test runner Damien Lespiau
2013-11-15 16:33 ` [PATCH 02/23] piglit: Import piglit Damien Lespiau
2013-11-15 16:33 ` [PATCH 03/23] piglit: Import igt.tests from piglit Damien Lespiau
2013-11-15 16:33 ` [PATCH 04/23] piglit: Adapt igt.tests to discover the tests directory itself Damien Lespiau
2013-11-15 16:33 ` [PATCH 05/23] piglit: Add a 'run-tests' Makefile target Damien Lespiau
2013-11-15 16:33 ` [PATCH 06/23] piglit: Add the option to inject piglit arguments Damien Lespiau
2013-11-15 16:33 ` [PATCH 07/23] piglit: Support resuming from a previous run Damien Lespiau
2013-11-15 16:33 ` [PATCH 08/23] piglit: Merge filters from previous invocations when resuming Damien Lespiau
2013-11-15 16:33 ` [PATCH 09/23] piglit: Fix resuming of previous runs Damien Lespiau
2013-11-15 16:33 ` [PATCH 10/23] piglit: Run our test suite with --no-concurrency Damien Lespiau
2013-11-15 17:08 ` Daniel Vetter [this message]
2013-11-15 17:17 ` Damien Lespiau
2013-11-15 16:33 ` [PATCH 11/23] piglit: Generate a Makefile.am from the sync script Damien Lespiau
2013-11-15 16:33 ` [PATCH 12/23] piglit: Always write the HTML test results Damien Lespiau
2013-11-15 16:33 ` [PATCH 13/23] piglit: Add a hint that there's an HTML summary Damien Lespiau
2013-11-15 16:33 ` [PATCH 14/23] framework: Humanize time values in the HTML report Damien Lespiau
2013-11-15 16:33 ` [PATCH 15/23] piglit: Support R= as RESUME= for the lazies Damien Lespiau
2013-11-15 16:33 ` [PATCH 16/23] drm_lib.sh: Tune the DRM master message a bit Damien Lespiau
2013-11-15 17:13 ` Daniel Vetter
2013-11-15 17:17 ` Damien Lespiau
2013-11-15 16:33 ` [PATCH 17/23] piglit: Make sure there's no DRM master before launching the tests Damien Lespiau
2013-11-15 16:33 ` [PATCH 18/23] piglit: Make sure we are running the tests as root Damien Lespiau
2013-11-15 16:33 ` [PATCH 19/23] piglit: Update the README file with the new way of running tests Damien Lespiau
2013-11-15 17:16 ` Daniel Vetter
2013-11-15 17:21 ` Damien Lespiau
2013-11-15 16:33 ` [PATCH 20/23] framework: Dump the result of 'uname -a' in the report Damien Lespiau
2013-11-15 16:33 ` [PATCH 21/23] lib: Introduce igt_run_quick() Damien Lespiau
2013-11-15 16:33 ` [PATCH 22/23] lib: Change SLOW_QUICK() to use igt_run_quick() Damien Lespiau
2013-11-15 16:33 ` [PATCH 23/23] pm_pc8: Use SLOW_QUICK() with the number of rounds Damien Lespiau
2013-11-15 17:20 ` [igt] Making the test-suite easier to run Damien Lespiau
2013-11-15 17:23 ` Daniel Vetter
2013-11-15 17:33 ` Mateo Lozano, Oscar
2013-11-15 17:41 ` Damien Lespiau
2013-11-15 19:27 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115170827.GV22741@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox