From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Fix gen3 self-refresh watermarks
Date: Wed, 20 Nov 2013 15:53:19 +0100 [thread overview]
Message-ID: <20131120145319.GC27344@phenom.ffwll.local> (raw)
In-Reply-To: <20131120144714.GB7819@intel.com>
On Wed, Nov 20, 2013 at 04:47:14PM +0200, Ville Syrjälä wrote:
> On Wed, Nov 20, 2013 at 03:02:10PM +0100, Daniel Vetter wrote:
> > This regression has been introduced in
> >
> > commit 4fe8590a921d0b2e36e542dbfa89a8c5993f5a3f
> > Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Date: Wed Sep 4 18:25:22 2013 +0300
> >
> > drm/i915: Use adjusted_mode appropriately when computing watermarks
> >
> > I guess we should renable the enabled local variable into something a
> > notch more descriptive, but that's something for -next.
> >
> > The effect on my i945gme netbook is pretty severe amounts of underruns
> > - usually the very first pixel gets used for the entire screeen.
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Damien Lespiau <damien.lespiau@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Dang. Copy paste fail on my part :( The fix looks good.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Queued for -next, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-11-20 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 14:02 [PATCH] drm/i915: Fix gen3 self-refresh watermarks Daniel Vetter
2013-11-20 14:47 ` Ville Syrjälä
2013-11-20 14:53 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120145319.GC27344@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox