From: Damien Lespiau <damien.lespiau@intel.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel: make sure VG_CLEAR() will always do memory clear
Date: Wed, 20 Nov 2013 16:59:22 +0000 [thread overview]
Message-ID: <20131120165922.GC32765@strange.amr.corp.intel.com> (raw)
In-Reply-To: <20131120155354.GA24338@zhen-hp.sh.intel.com>
On Wed, Nov 20, 2013 at 11:53:54PM +0800, Zhenyu Wang wrote:
> > VG_CLEAR() is really just for valgrind. If you need to set some specific
> > variable/field to 0 then you need to set it to 0 and not rely on
> > VG_CLEAR() to do it for you.
> >
>
> ok, in valgrind case it does memory clear for ioctl args which I think is
> good behavior in non-valgrind case too.
Ian just submitted a patch that memset the whole structure.
> > What's the actual issue you have?
> >
>
> During testing on recent get reset status ioctl, if !HAVE_VALGRIND, stats
> argument is not cleared, which failed in kernel check.
Right, so the fix is (was) to zero the fields checked by the kernel
explicitely, not change the VG() macro, which is just used in testing
(and it should this way).
HTH,
--
Damien
next prev parent reply other threads:[~2013-11-20 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 9:22 [PATCH] intel: make sure VG_CLEAR() will always do memory clear Zhenyu Wang
2013-11-20 11:36 ` Damien Lespiau
2013-11-20 15:53 ` Zhenyu Wang
2013-11-20 16:59 ` Damien Lespiau [this message]
2013-11-21 2:16 ` Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120165922.GC32765@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox