Re: [PATCH] intel: make sure VG_CLEAR() will always do memory clear

[Damien Lespiau <damien.lespiau@intel.com>]

On Wed, Nov 20, 2013 at 05:22:48PM +0800, Zhenyu Wang wrote:
> If valgrind is not available, current VG_CLEAR() would just ignore
> memory clear operation which might make invalid ioctl argument. So
> make sure VG_CLEAR() will always clear memory.
> ---
>  intel/intel_bufmgr_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
> index df6fcec..389f73a 100644
> --- a/intel/intel_bufmgr_gem.c
> +++ b/intel/intel_bufmgr_gem.c
> @@ -74,7 +74,7 @@
>  #define VG(x)
>  #endif
>  
> -#define VG_CLEAR(s) VG(memset(&s, 0, sizeof(s)))
> +#define VG_CLEAR(s) (memset(&s, 0, sizeof(s)))

VG_CLEAR() is really just for valgrind. If you need to set some specific
variable/field to 0 then you need to set it to 0 and not rely on
VG_CLEAR() to do it for you.

What's the actual issue you have?

-- 
Damien