Re: [PATCH] drm/i915: Fix module unloading with DRM_I915_UMS=n

[Daniel Vetter <daniel@ffwll.ch>]

On Fri, Nov 22, 2013 at 05:25:41PM -0200, Paulo Zanoni wrote:
> 2013/11/15 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > Oops, makes testing early boot failures in i915.ko a bit more pain, so
> > let's fix it.
> >
> > v2: We already have a bit of static storage to track this (Chris).
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> I can reproduce the failure by booting with i915.modeset=0, then get
> the oops when "rmmod i915".
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> I also looked at Chris' patch. I think that since we take the early
> "return 0" inside i915_init, we never call drm_pci_init, so it doesn't
> make too much sense to fix the problem inside drm_pci_exit.

Thanks for review&testing, patch merged.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch