From: Damien Lespiau <damien.lespiau@intel.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: piglit discussion list <piglit@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] tests/igt: Add runtime environment checks
Date: Tue, 26 Nov 2013 19:53:33 +0000 [thread overview]
Message-ID: <20131126195332.GC32421@strange.icx.intel.com> (raw)
In-Reply-To: <20131126194942.GD27358@bwidawsk.net>
On Tue, Nov 26, 2013 at 11:49:43AM -0800, Ben Widawsky wrote:
> > Only in the make target he created, not in piglit itself. Imo we should
> > have all the testrunner logic in one place, i.e. in the piglit sources.
> > -Daniel
>
> Damien, can you comment? I could have sworn you said something different
> on IRC. It sounded like exactly what I wanted.
What Daniel says is correct, the check is part of the runner wrapper,
not piglit itself.
I'd rather have a environement check up-front and I don't mind where it
lives (igt Vs piglit).
--
Damien
next prev parent reply other threads:[~2013-11-26 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 8:09 [PATCH] tests/igt: Add runtime environment checks Daniel Vetter
2013-11-26 19:05 ` Ben Widawsky
[not found] ` <20131126190556.GB27358-Egm8mFWDmf3k1uMJSBkQmQ@public.gmane.org>
2013-11-26 19:46 ` Daniel Vetter
[not found] ` <20131126194619.GS27344-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2013-11-26 19:49 ` Ben Widawsky
2013-11-26 19:53 ` Damien Lespiau [this message]
[not found] ` <20131126195332.GC32421-q+Y1yDQJ1rKUyhp/hE4EWxL4W9x8LtSr@public.gmane.org>
2013-11-26 19:55 ` Daniel Vetter
[not found] ` <CAKMK7uEeyNShA8fAF82+prCgYTVd2G60GLVMCCVy56p2uRGeJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-26 20:02 ` Ben Widawsky
[not found] ` <20131126200238.GE27358-Egm8mFWDmf3k1uMJSBkQmQ@public.gmane.org>
2013-11-26 21:51 ` Daniel Vetter
[not found] ` <1385453344-25217-1-git-send-email-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2013-11-26 21:15 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126195332.GC32421@strange.icx.intel.com \
--to=damien.lespiau@intel.com \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=piglit@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox