From: Daniel Vetter <daniel@ffwll.ch>
To: "S, Deepak" <deepak.s@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/i915: Enabling DebugFS for valleyview forcewake counts
Date: Wed, 27 Nov 2013 16:59:52 +0100 [thread overview]
Message-ID: <20131127155951.GZ27344@phenom.ffwll.local> (raw)
In-Reply-To: <F359EE24E0B97E4A9739736D2C188EF3FAF6EA@BGSMSX102.gar.corp.intel.com>
On Tue, Nov 26, 2013 at 10:12:48AM +0000, S, Deepak wrote:
> Yes Jesse, this is a warning fix.
Yeah, those should be separate or at least mentioned in the commit
message. But I have this one already so it naturally dropped out. All
three patches merged to dinq, thanks.
-Daniel
>
> -----Original Message-----
> From: Jesse Barnes [mailto:jbarnes@virtuousgeek.org]
> Sent: Monday, November 25, 2013 10:09 PM
> To: S, Deepak
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: Enabling DebugFS for valleyview forcewake counts
>
> On Sat, 23 Nov 2013 14:55:44 +0530
> deepak.s@intel.com wrote:
> > @@ -2349,7 +2357,7 @@ static int pipe_crc_set_source(struct drm_device
> > *dev, enum pipe pipe, {
> > struct drm_i915_private *dev_priv = dev->dev_private;
> > struct intel_pipe_crc *pipe_crc = &dev_priv->pipe_crc[pipe];
> > - u32 val;
> > + u32 val = 0;
> > int ret;
> >
> > if (pipe_crc->source == source)
>
> Spurious warning fix? Otherwise looks fine.
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> --
> Jesse Barnes, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-11-27 15:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 9:25 [PATCH 0/3] drm/i915: Split VLV forcewake routines deepak.s
2013-11-23 9:25 ` [PATCH 1/3] drm/i915: Add power well arguments to force wake routines deepak.s
2013-11-25 16:29 ` Jesse Barnes
2013-11-23 9:25 ` [PATCH 2/3] drm/i915/vlv: Valleyview support for forcewake Individual power wells deepak.s
2013-11-25 14:48 ` Chris Wilson
2013-11-26 10:10 ` S, Deepak
2013-11-25 16:36 ` Jesse Barnes
2013-11-23 9:25 ` [PATCH 3/3] drm/i915: Enabling DebugFS for valleyview forcewake counts deepak.s
2013-11-25 16:38 ` Jesse Barnes
2013-11-26 10:12 ` S, Deepak
2013-11-27 15:59 ` Daniel Vetter [this message]
2013-11-27 16:30 ` S, Deepak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127155951.GZ27344@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=deepak.s@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox