From: Damien Lespiau <damien.lespiau@intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: drop DRM_ERROR in intel_fbdev init
Date: Thu, 28 Nov 2013 12:17:32 +0000 [thread overview]
Message-ID: <20131128121732.GA30039@strange.amr.corp.intel.com> (raw)
In-Reply-To: <1385493954-2301-1-git-send-email-jbarnes@virtuousgeek.org>
On Tue, Nov 26, 2013 at 11:25:54AM -0800, Jesse Barnes wrote:
> This should just be a debug. Add another debug msg to the inherit path
> while we're at it.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72098
> ---
> drivers/gpu/drm/i915/intel_fbdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
> index fdb6dc9..284c3eb 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -127,11 +127,12 @@ static int intelfb_create(struct drm_fb_helper *helper,
> mutex_lock(&dev->struct_mutex);
>
> if (!intel_fb->obj) {
> - DRM_ERROR("no BIOS fb, allocating a new one\n");
> + DRM_DEBUG_KMS("no BIOS fb, allocating a new one\n");
> ret = intelfb_alloc(helper, sizes);
> if (ret)
> goto out_unlock;
> } else {
> + DRM_DEBUG_KMS("re-using BIOS fb\n");
> sizes->fb_width = intel_fb->base.width;
> sizes->fb_height = intel_fb->base.height;
> }
> --
> 1.8.4.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-11-28 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 19:25 [PATCH] drm/i915: drop DRM_ERROR in intel_fbdev init Jesse Barnes
2013-11-28 12:17 ` Damien Lespiau [this message]
2013-11-28 13:56 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128121732.GA30039@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox