[PATCH] drm/i915: drop DRM_ERROR in intel_fbdev init

[PATCH] drm/i915: drop DRM_ERROR in intel_fbdev init

[Jesse Barnes]

This should just be a debug.  Add another debug msg to the inherit path
while we're at it.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_fbdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
index fdb6dc9..284c3eb 100644
--- a/drivers/gpu/drm/i915/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/intel_fbdev.c
@@ -127,11 +127,12 @@ static int intelfb_create(struct drm_fb_helper *helper,
 	mutex_lock(&dev->struct_mutex);
 
 	if (!intel_fb->obj) {
-		DRM_ERROR("no BIOS fb, allocating a new one\n");
+		DRM_DEBUG_KMS("no BIOS fb, allocating a new one\n");
 		ret = intelfb_alloc(helper, sizes);
 		if (ret)
 			goto out_unlock;
 	} else {
+		DRM_DEBUG_KMS("re-using BIOS fb\n");
 		sizes->fb_width = intel_fb->base.width;
 		sizes->fb_height = intel_fb->base.height;
 	}
-- 
1.8.4.2

Re: [PATCH] drm/i915: drop DRM_ERROR in intel_fbdev init

[Damien Lespiau]

On Tue, Nov 26, 2013 at 11:25:54AM -0800, Jesse Barnes wrote:
> This should just be a debug.  Add another debug msg to the inherit path
> while we're at it.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>


Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72098


> ---
>  drivers/gpu/drm/i915/intel_fbdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
> index fdb6dc9..284c3eb 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -127,11 +127,12 @@ static int intelfb_create(struct drm_fb_helper *helper,
>  	mutex_lock(&dev->struct_mutex);
>  
>  	if (!intel_fb->obj) {
> -		DRM_ERROR("no BIOS fb, allocating a new one\n");
> +		DRM_DEBUG_KMS("no BIOS fb, allocating a new one\n");
>  		ret = intelfb_alloc(helper, sizes);
>  		if (ret)
>  			goto out_unlock;
>  	} else {
> +		DRM_DEBUG_KMS("re-using BIOS fb\n");
>  		sizes->fb_width = intel_fb->base.width;
>  		sizes->fb_height = intel_fb->base.height;
>  	}
> -- 
> 1.8.4.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: drop DRM_ERROR in intel_fbdev init

[Daniel Vetter]

On Thu, Nov 28, 2013 at 12:17:32PM +0000, Damien Lespiau wrote:
> On Tue, Nov 26, 2013 at 11:25:54AM -0800, Jesse Barnes wrote:
> > This should just be a debug.  Add another debug msg to the inherit path
> > while we're at it.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> 
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72098

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch