* [PATCH] drm: fix the addition of the side-by-side (half) flag for extra 3D modes
@ 2013-11-28 15:35 Thomas Wood
2013-11-28 15:41 ` Ville Syrjälä
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Wood @ 2013-11-28 15:35 UTC (permalink / raw)
To: dri-devel, intel-gfx
Ensure the side-by-side (half) flag is added to any existing flags when
adding modes from 3D_Structure_ALL.
Signed-off-by: Thomas Wood <thomas.wood@intel.com>
---
drivers/gpu/drm/drm_edid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index fb7cf0e..52e060e 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -2701,7 +2701,7 @@ static int add_3d_struct_modes(struct drm_connector *connector, u16 structure,
if (structure & (1 << 8)) {
newmode = drm_mode_duplicate(dev, &edid_cea_modes[cea_mode]);
if (newmode) {
- newmode->flags = DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF;
+ newmode->flags |= DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF;
drm_mode_probed_add(connector, newmode);
modes++;
}
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: fix the addition of the side-by-side (half) flag for extra 3D modes
2013-11-28 15:35 [PATCH] drm: fix the addition of the side-by-side (half) flag for extra 3D modes Thomas Wood
@ 2013-11-28 15:41 ` Ville Syrjälä
0 siblings, 0 replies; 2+ messages in thread
From: Ville Syrjälä @ 2013-11-28 15:41 UTC (permalink / raw)
To: Thomas Wood; +Cc: intel-gfx, dri-devel
On Thu, Nov 28, 2013 at 03:35:04PM +0000, Thomas Wood wrote:
> Ensure the side-by-side (half) flag is added to any existing flags when
> adding modes from 3D_Structure_ALL.
>
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_edid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index fb7cf0e..52e060e 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -2701,7 +2701,7 @@ static int add_3d_struct_modes(struct drm_connector *connector, u16 structure,
> if (structure & (1 << 8)) {
> newmode = drm_mode_duplicate(dev, &edid_cea_modes[cea_mode]);
> if (newmode) {
> - newmode->flags = DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF;
> + newmode->flags |= DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF;
> drm_mode_probed_add(connector, newmode);
> modes++;
> }
> --
> 1.8.4.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-28 15:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-28 15:35 [PATCH] drm: fix the addition of the side-by-side (half) flag for extra 3D modes Thomas Wood
2013-11-28 15:41 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox