From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Return a drm_mode_status enum in the mode_valid vfuncs
Date: Mon, 2 Dec 2013 14:42:56 +0100 [thread overview]
Message-ID: <20131202134255.GA7281@ulmo.nvidia.com> (raw)
In-Reply-To: <20131128154952.GN27344@phenom.ffwll.local>
[-- Attachment #1.1: Type: text/plain, Size: 943 bytes --]
On Thu, Nov 28, 2013 at 04:49:52PM +0100, Daniel Vetter wrote:
> On Thu, Nov 28, 2013 at 03:29:18PM +0000, Damien Lespiau wrote:
> > We had some mode_valid() vfuncs returning an int, others the enum. Let's
> > use the latter everywhere.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>
> Yeah, makes sense. Queued for -next, thanks for the patch.
>
> -Daniel
> > ---
> > drivers/gpu/drm/i915/intel_crt.c | 5 +++--
> > drivers/gpu/drm/i915/intel_dp.c | 2 +-
> > drivers/gpu/drm/i915/intel_dsi.c | 5 +++--
> > drivers/gpu/drm/i915/intel_dvo.c | 5 +++--
> > drivers/gpu/drm/i915/intel_hdmi.c | 5 +++--
> > drivers/gpu/drm/i915/intel_lvds.c | 5 +++--
> > drivers/gpu/drm/i915/intel_sdvo.c | 5 +++--
> > 7 files changed, 19 insertions(+), 13 deletions(-)
Shouldn't you be updating all other drivers as well? GCC doesn't seem to
complain about it, but it's still an inconsistency.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-12-02 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 15:29 [PATCH 1/2] drm: Make the connector mode_valid() vfunc return a drm_mode_status enum Damien Lespiau
2013-11-28 15:29 ` [PATCH 2/2] drm/i915: Return a drm_mode_status enum in the mode_valid vfuncs Damien Lespiau
2013-11-28 15:49 ` Daniel Vetter
2013-12-02 13:42 ` Thierry Reding [this message]
2013-11-28 15:49 ` [PATCH 1/2] drm: Make the connector mode_valid() vfunc return a drm_mode_status enum Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202134255.GA7281@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox