From: Daniel Vetter <daniel@ffwll.ch>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/2] drmtest: Fix hanging child processes
Date: Tue, 3 Dec 2013 17:59:49 +0100 [thread overview]
Message-ID: <20131203165949.GK27344@phenom.ffwll.local> (raw)
In-Reply-To: <1386089095-9966-1-git-send-email-tvrtko.ursulin@linux.intel.com>
On Tue, Dec 03, 2013 at 04:44:53PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> It was observed both on Linux and Android that tests which
> fork can sometimes hang failing to terminate child
> processes.
>
> This was eventually tracked down to race conditions in C
> library implementations, all with regards to caching of
> PID/TGID and TID values.
>
> Solution is to revert the previous workaround, which closed
> the race under glibc a bit, and ensure current values from
> the kernel are used during timing sensitive periods.
>
> This was tested under Android only but should be a generic fix.
>
> Tvrtko Ursulin (2):
> Revert "lib/drmtest: ducttape over fork race"
> drmtest: Avoid wrong PID/TID after clone races
Both merged, thanks for the patches.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-12-03 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 16:44 [PATCH 0/2] drmtest: Fix hanging child processes Tvrtko Ursulin
2013-12-03 16:44 ` [PATCH 1/2] Revert "lib/drmtest: ducttape over fork race" Tvrtko Ursulin
2013-12-03 16:44 ` [PATCH 2/2] drmtest: Avoid wrong PID/TID after clone races Tvrtko Ursulin
2013-12-03 16:59 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203165949.GK27344@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox