From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/2] Revert "lib/drmtest: ducttape over fork race"
Date: Tue, 3 Dec 2013 16:44:54 +0000 [thread overview]
Message-ID: <1386089095-9966-2-git-send-email-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <1386089095-9966-1-git-send-email-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
This reverts commit a031a1bf93b828585e7147f06145fc5030814547.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Conflicts:
lib/drmtest.c
---
lib/drmtest.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index 94fa686..dcacd3b 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -1127,7 +1127,6 @@ static void fork_helper_exit_handler(int sig)
bool __igt_fork_helper(struct igt_helper_process *proc)
{
pid_t pid;
- sighandler_t oldsig;
int id;
assert(!proc->running);
@@ -1138,13 +1137,6 @@ bool __igt_fork_helper(struct igt_helper_process *proc)
igt_install_exit_handler(fork_helper_exit_handler);
- /*
- * XXX: There's a race between fork and the subsequent kill in
- * igt_stop_signal_helper if we don't ovewrite the SIGQUIT handler. Note
- * that inserting sufficient amounts of printf or other delays makes
- * this unnecessary.
- */
- oldsig = signal(SIGQUIT, SIG_DFL);
switch (pid = fork()) {
case -1:
igt_assert(0);
@@ -1155,8 +1147,6 @@ bool __igt_fork_helper(struct igt_helper_process *proc)
return true;
default:
- signal(SIGQUIT, oldsig);
-
proc->running = true;
proc->pid = pid;
proc->id = id;
--
1.8.4.3
next prev parent reply other threads:[~2013-12-03 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 16:44 [PATCH 0/2] drmtest: Fix hanging child processes Tvrtko Ursulin
2013-12-03 16:44 ` Tvrtko Ursulin [this message]
2013-12-03 16:44 ` [PATCH 2/2] drmtest: Avoid wrong PID/TID after clone races Tvrtko Ursulin
2013-12-03 16:59 ` [PATCH 0/2] drmtest: Fix hanging child processes Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386089095-9966-2-git-send-email-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox