public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Skip clock checks on BDW
@ 2013-12-02  9:23 ville.syrjala
  2013-12-02 14:01 ` Damien Lespiau
  0 siblings, 1 reply; 3+ messages in thread
From: ville.syrjala @ 2013-12-02  9:23 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We don't have clock state readout support for DDI, so skip the pipe
config clock checks on all DDI platforms.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 680685f..1c48edf 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9146,7 +9146,7 @@ intel_pipe_config_compare(struct drm_device *dev,
 	if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5)
 		PIPE_CONF_CHECK_I(pipe_bpp);
 
-	if (!IS_HASWELL(dev)) {
+	if (!HAS_DDI(dev)) {
 		PIPE_CONF_CHECK_CLOCK_FUZZY(adjusted_mode.crtc_clock);
 		PIPE_CONF_CHECK_CLOCK_FUZZY(port_clock);
 	}
-- 
1.8.3.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/i915: Skip clock checks on BDW
  2013-12-02  9:23 [PATCH] drm/i915: Skip clock checks on BDW ville.syrjala
@ 2013-12-02 14:01 ` Damien Lespiau
  2013-12-03 17:18   ` Daniel Vetter
  0 siblings, 1 reply; 3+ messages in thread
From: Damien Lespiau @ 2013-12-02 14:01 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

On Mon, Dec 02, 2013 at 11:23:39AM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> We don't have clock state readout support for DDI, so skip the pipe
> config clock checks on all DDI platforms.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

-- 
Damien

> ---
>  drivers/gpu/drm/i915/intel_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 680685f..1c48edf 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9146,7 +9146,7 @@ intel_pipe_config_compare(struct drm_device *dev,
>  	if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5)
>  		PIPE_CONF_CHECK_I(pipe_bpp);
>  
> -	if (!IS_HASWELL(dev)) {
> +	if (!HAS_DDI(dev)) {
>  		PIPE_CONF_CHECK_CLOCK_FUZZY(adjusted_mode.crtc_clock);
>  		PIPE_CONF_CHECK_CLOCK_FUZZY(port_clock);
>  	}
> -- 
> 1.8.3.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/i915: Skip clock checks on BDW
  2013-12-02 14:01 ` Damien Lespiau
@ 2013-12-03 17:18   ` Daniel Vetter
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2013-12-03 17:18 UTC (permalink / raw)
  To: Damien Lespiau; +Cc: intel-gfx

On Mon, Dec 02, 2013 at 02:01:45PM +0000, Damien Lespiau wrote:
> On Mon, Dec 02, 2013 at 11:23:39AM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > We don't have clock state readout support for DDI, so skip the pipe
> > config clock checks on all DDI platforms.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-12-03 17:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-02  9:23 [PATCH] drm/i915: Skip clock checks on BDW ville.syrjala
2013-12-02 14:01 ` Damien Lespiau
2013-12-03 17:18   ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox