From: Damien Lespiau <damien.lespiau@intel.com>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't cast away const from infoframe buffer
Date: Tue, 10 Dec 2013 12:25:26 +0000 [thread overview]
Message-ID: <20131210122526.GC27411@strange.amr.corp.intel.com> (raw)
In-Reply-To: <1386677190-7217-1-git-send-email-ville.syrjala@linux.intel.com>
On Tue, Dec 10, 2013 at 02:06:30PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We don't modify the packed infoframe data, so we should keep the
> const qualifier in place. Just pass the buffer as 'const void *'
> instead of 'const uint8_t *' and we can drop the cast entirely.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
(I guess the data argument of intel_sdvo_write_infoframe() could be
constified as well)
--
Damien
> ---
> drivers/gpu/drm/i915/intel_drv.h | 2 +-
> drivers/gpu/drm/i915/intel_hdmi.c | 20 ++++++++++----------
> 2 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index ea62673..852ed41 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -454,7 +454,7 @@ struct intel_hdmi {
> bool rgb_quant_range_selectable;
> void (*write_infoframe)(struct drm_encoder *encoder,
> enum hdmi_infoframe_type type,
> - const uint8_t *frame, ssize_t len);
> + const void *frame, ssize_t len);
> void (*set_infoframes)(struct drm_encoder *encoder,
> struct drm_display_mode *adjusted_mode);
> };
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 6a6ad0c..6db0d9d 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -130,9 +130,9 @@ static u32 hsw_infoframe_data_reg(enum hdmi_infoframe_type type,
>
> static void g4x_write_infoframe(struct drm_encoder *encoder,
> enum hdmi_infoframe_type type,
> - const uint8_t *frame, ssize_t len)
> + const void *frame, ssize_t len)
> {
> - uint32_t *data = (uint32_t *)frame;
> + const uint32_t *data = frame;
> struct drm_device *dev = encoder->dev;
> struct drm_i915_private *dev_priv = dev->dev_private;
> u32 val = I915_READ(VIDEO_DIP_CTL);
> @@ -167,9 +167,9 @@ static void g4x_write_infoframe(struct drm_encoder *encoder,
>
> static void ibx_write_infoframe(struct drm_encoder *encoder,
> enum hdmi_infoframe_type type,
> - const uint8_t *frame, ssize_t len)
> + const void *frame, ssize_t len)
> {
> - uint32_t *data = (uint32_t *)frame;
> + const uint32_t *data = frame;
> struct drm_device *dev = encoder->dev;
> struct drm_i915_private *dev_priv = dev->dev_private;
> struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
> @@ -205,9 +205,9 @@ static void ibx_write_infoframe(struct drm_encoder *encoder,
>
> static void cpt_write_infoframe(struct drm_encoder *encoder,
> enum hdmi_infoframe_type type,
> - const uint8_t *frame, ssize_t len)
> + const void *frame, ssize_t len)
> {
> - uint32_t *data = (uint32_t *)frame;
> + const uint32_t *data = frame;
> struct drm_device *dev = encoder->dev;
> struct drm_i915_private *dev_priv = dev->dev_private;
> struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
> @@ -246,9 +246,9 @@ static void cpt_write_infoframe(struct drm_encoder *encoder,
>
> static void vlv_write_infoframe(struct drm_encoder *encoder,
> enum hdmi_infoframe_type type,
> - const uint8_t *frame, ssize_t len)
> + const void *frame, ssize_t len)
> {
> - uint32_t *data = (uint32_t *)frame;
> + const uint32_t *data = frame;
> struct drm_device *dev = encoder->dev;
> struct drm_i915_private *dev_priv = dev->dev_private;
> struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
> @@ -284,9 +284,9 @@ static void vlv_write_infoframe(struct drm_encoder *encoder,
>
> static void hsw_write_infoframe(struct drm_encoder *encoder,
> enum hdmi_infoframe_type type,
> - const uint8_t *frame, ssize_t len)
> + const void *frame, ssize_t len)
> {
> - uint32_t *data = (uint32_t *)frame;
> + const uint32_t *data = frame;
> struct drm_device *dev = encoder->dev;
> struct drm_i915_private *dev_priv = dev->dev_private;
> struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-12-10 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 12:06 [PATCH] drm/i915: Don't cast away const from infoframe buffer ville.syrjala
2013-12-10 12:25 ` Damien Lespiau [this message]
2013-12-10 13:19 ` [PATCH v2] " ville.syrjala
2013-12-10 13:49 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210122526.GC27411@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox