From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 8/8] drm/i915: Enable FBC for all mobile gen2 and gen3 platforms
Date: Thu, 12 Dec 2013 16:04:52 +0100 [thread overview]
Message-ID: <20131212150452.GN9804@phenom.ffwll.local> (raw)
In-Reply-To: <CAKMK7uHmUWaNhRnnYUA3sPO0QkXa_Eg_jvd9EhK1M2y2cabDOQ@mail.gmail.com>
On Thu, Dec 12, 2013 at 03:38:38PM +0100, Daniel Vetter wrote:
> On Thu, Dec 12, 2013 at 3:32 PM, Ville Syrjälä
> <ville.syrjala@linux.intel.com> wrote:
> > On Thu, Dec 12, 2013 at 04:19:34PM +0200, Imre Deak wrote:
> >> On Thu, 2013-11-28 at 17:30 +0200, ville.syrjala@linux.intel.com wrote:
> >> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> >
> >> > All mobile gen2 and gen3 chipsets should have FBC1, and the code
> >> > should now handle them all. So just set has_fbc=true for all such
> >> > chipsets.
> >> >
> >> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >>
> >> Based on the above we could also enable fbc for i830. In any case:
> >> Reviewed-by: Imre Deak <imre.deak@intel.com>
> >
> > According to the spec there's no FBC on 830, so I guess my commit
> > message was a tad incorrect. Some part of the spec hints that FBC
> > might be avilable on 865 too, but in another part only 85x is
> > mentioned.
>
> Iirc fbc was mobile-only until ilk happened. So by that pattern I
> wouldn't expect 865 to have it, since it's a desktop part.
Ok I've merged 3 more patches from this series, but the last one kinda
refused to apply on dinq. Can you please rebase?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-12-12 15:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 15:29 [PATCH 0/8] FBC support for gen2/3 ville.syrjala
2013-11-28 15:29 ` [PATCH 1/8] drm/i915: Fix bogus FBC1 defines ville.syrjala
2013-11-29 13:59 ` Chris Wilson
2013-11-28 15:29 ` [PATCH 2/8] drm/i915: Gen2 FBC1 CFB pitch wants 32B units ville.syrjala
2013-12-12 12:54 ` Imre Deak
2013-11-28 15:29 ` [PATCH 3/8] drm/i915: FBC_CONTROL2 is gen4 only ville.syrjala
2013-11-29 14:01 ` Chris Wilson
2013-12-12 13:00 ` Imre Deak
2013-12-12 14:59 ` Daniel Vetter
2013-11-28 15:29 ` [PATCH 4/8] drm/i915: Fix FBC1 plane checks for gen2 ville.syrjala
2013-11-29 13:57 ` Chris Wilson
2013-11-28 15:29 ` [PATCH 5/8] drm/i915: Reorganize FBC function pointer initializaition ville.syrjala
2013-11-29 13:59 ` Chris Wilson
2013-11-28 15:30 ` [PATCH 6/8] drm/i915: Rework the FBC interval/stall stuff a bit ville.syrjala
2013-11-29 13:53 ` Chris Wilson
2013-12-12 14:04 ` Imre Deak
2013-12-12 15:03 ` Daniel Vetter
2013-12-12 15:27 ` [PATCH v2 " ville.syrjala
2013-12-12 16:45 ` Daniel Vetter
2013-11-28 15:30 ` [PATCH 7/8] drm/i915: Swap primary planes on gen2 for FBC ville.syrjala
2013-11-29 13:55 ` Chris Wilson
2013-12-03 21:35 ` Daniel Vetter
2013-11-28 15:30 ` [PATCH 8/8] drm/i915: Enable FBC for all mobile gen2 and gen3 platforms ville.syrjala
2013-11-29 13:56 ` Chris Wilson
2013-11-29 14:10 ` Daniel Vetter
2013-11-29 14:15 ` Chris Wilson
2013-11-29 14:39 ` Ville Syrjälä
2013-12-12 14:19 ` Imre Deak
2013-12-12 14:32 ` Ville Syrjälä
2013-12-12 14:38 ` Daniel Vetter
2013-12-12 15:04 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212150452.GN9804@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox