From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: dont call irq_put when irq test is on
Date: Thu, 12 Dec 2013 17:46:47 +0100 [thread overview]
Message-ID: <20131212164647.GP9804@phenom.ffwll.local> (raw)
In-Reply-To: <20131212160616.GC10036@intel.com>
On Thu, Dec 12, 2013 at 06:06:16PM +0200, Ville Syrjälä wrote:
> On Thu, Dec 12, 2013 at 05:54:42PM +0200, Mika Kuoppala wrote:
> > If test is running, irq_get was not called so we should gain
> > balance by not doing irq_put
> >
> > "So the rule is: if you access unlocked values, you use ACCESS_ONCE().
> > You don't say "but it can't matter". Because you simply don't know."
> > -- Linus
> >
> > v2: use local variable so it can't change during test (Chris)
> >
> > v3: update commit msg and use ACCESS_ONCE (Ville)
> >
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> Looks good.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-12-12 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 18:47 [PATCH] drm/i915: dont call irq_put when irq test is on Mika Kuoppala
2013-12-12 12:56 ` Ville Syrjälä
2013-12-12 15:54 ` Mika Kuoppala
2013-12-12 16:06 ` Ville Syrjälä
2013-12-12 16:46 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212164647.GP9804@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox