From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/bdw: don't try to check IPS state on BDW
Date: Tue, 7 Jan 2014 13:33:44 -0800 [thread overview]
Message-ID: <20140107133344.4565814d@jbarnes-desktop> (raw)
In-Reply-To: <CA+gsUGSr02dJomUNjjAGpuM4i_UtRBuVF6sB2Lxfdw+BRuYKAg@mail.gmail.com>
On Tue, 7 Jan 2014 17:49:05 -0200
Paulo Zanoni <przanoni@gmail.com> wrote:
> 2014/1/6 Jesse Barnes <jbarnes@virtuousgeek.org>:
> > According to Art, we don't have a way to read back the state reliably at
> > runtime, at least not without risking disabling it again. So drop the
> > readout and checking on BDW.
>
> Based on that, we also need to:
> - Replace the TODO comment at hsw_enable_ips() with something else
> - Move the POSTING_READ() at hsw_disable_ips() to the IS_HASWELL() case
> - Print "enisabled" when someone reads i915_ips_status on BDW
All good changes. Just sent an updated patch.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2014-01-07 21:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 0:28 [PATCH] drm/i915/bdw: don't try to check IPS state on BDW Jesse Barnes
2014-01-07 19:49 ` Paulo Zanoni
2014-01-07 21:30 ` [PATCH] drm/i915/bdw: don't try to check IPS state on BDW v2 Jesse Barnes
2014-01-08 14:00 ` Paulo Zanoni
2014-01-07 21:33 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107133344.4565814d@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox