From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Only WARN about a stuck hotplug irq ONCE
Date: Fri, 10 Jan 2014 20:57:03 +0100 [thread overview]
Message-ID: <20140110195703.GK4770@phenom.ffwll.local> (raw)
In-Reply-To: <1389379761-16837-1-git-send-email-chris@chris-wilson.co.uk>
On Fri, Jan 10, 2014 at 06:49:20PM +0000, Chris Wilson wrote:
> It seems that hardware that is broken enough to emit a hotplug IRQ even
> though the pin is surposedly disable, will do so indefinitely.
>
> References: https://bugzilla.redhat.com/show_bug.cgi?id=1051170
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=1051369
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
gm45, unsurprisingly ... Underlying cause should be fixed with
commit 0ce99f749b3834edeb500e17d6ad17e86b60ff83
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Fri Jul 26 11:27:49 2013 +0200
drm/i915: fix gen4 digital port hotplug definitions
Or at least that's my hope. For further debug help, care to also dump the
hotplug_trigger bits in the format string while at it?
-Daniel
> ---
> drivers/gpu/drm/i915/i915_irq.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index ec67bb8aff0a..3be8bcd4d797 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1247,9 +1247,9 @@ static inline void intel_hpd_irq_handler(struct drm_device *dev,
> spin_lock(&dev_priv->irq_lock);
> for (i = 1; i < HPD_NUM_PINS; i++) {
>
> - WARN(((hpd[i] & hotplug_trigger) &&
> - dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED),
> - "Received HPD interrupt although disabled\n");
> + WARN_ONCE(hpd[i] & hotplug_trigger &&
> + dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED,
> + "Received HPD interrupt although disabled\n");
>
> if (!(hpd[i] & hotplug_trigger) ||
> dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED)
> --
> 1.8.5.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-01-10 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 18:49 [PATCH 1/2] drm/i915: Only WARN about a stuck hotplug irq ONCE Chris Wilson
2014-01-10 18:49 ` [PATCH 2/2] drm/i915: Only complain about a rogue hotplug IRQ after disabling Chris Wilson
2014-01-10 18:52 ` [PATCH 1/2] drm/i915: Only WARN about a stuck hotplug irq ONCE Chris Wilson
2014-01-10 19:57 ` Daniel Vetter [this message]
2014-01-10 20:17 ` [PATCH] drm/i915: Include more information in disabled hotplug interrupt warning Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110195703.GK4770@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox