From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Alan Stern <stern@rowland.harvard.edu>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: read lvds_border_bits state from encoder->get_config
Date: Mon, 27 Jan 2014 11:18:20 +0100 [thread overview]
Message-ID: <20140127101820.GZ9772@phenom.ffwll.local> (raw)
In-Reply-To: <20140127095711.GD5258@nuc-i3427.alporthouse.com>
On Mon, Jan 27, 2014 at 09:57:11AM +0000, Chris Wilson wrote:
> On Mon, Jan 27, 2014 at 10:00:31AM +0100, Daniel Vetter wrote:
> > We seem to get confused when trying to reconstruct this from the pipe
> > get_config when reading out pfit state. In our code these two are
> > connected, but in the hardware they're not.
>
> Huh? I think the change is to only read out the border-enable bit when
> LVDS is enabled. But that is only a guess at what your intent is here.
Yeah, that's the idea. The encoder specific get_config is only called if
get_hw_state indicates that the encoder is on. Since we always reset the
lvds border bits in the lvds->mode_set callback to the one in the pipe
config this should fix the mismatch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-01-27 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 9:00 [PATCH 1/2] drm/i915: Don't set the 8to6 dither flag when not scaling Daniel Vetter
2014-01-27 9:00 ` [PATCH 2/2] drm/i915: read lvds_border_bits state from encoder->get_config Daniel Vetter
2014-01-27 9:57 ` [Intel-gfx] " Chris Wilson
2014-01-27 10:18 ` Daniel Vetter [this message]
2014-04-13 9:52 ` [PATCH 1/2] drm/i915: Don't set the 8to6 dither flag when not scaling Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127101820.GZ9772@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox