From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Treat using a purged buffer as a source of EFAULT
Date: Tue, 4 Feb 2014 12:05:13 +0100 [thread overview]
Message-ID: <20140204110513.GJ17001@phenom.ffwll.local> (raw)
In-Reply-To: <1391168098-23161-2-git-send-email-chris@chris-wilson.co.uk>
On Fri, Jan 31, 2014 at 11:34:58AM +0000, Chris Wilson wrote:
> Since a purged buffer is one without any associated pages, attempting to
> use it should generate EFAULT rather than EINVAL, as it is not strictly
> an invalid parameter.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Care to drop a quick testcase into i-g-t to encode this return value
change? Also, any plans to use this with userspace somehow, or what's the
motivation for this?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-02-04 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 11:34 [PATCH 1/2] drm/i915: Convert EFAULT into a silent SIGBUS Chris Wilson
2014-01-31 11:34 ` [PATCH 2/2] drm/i915: Treat using a purged buffer as a source of EFAULT Chris Wilson
2014-02-04 11:05 ` Daniel Vetter [this message]
2014-02-04 11:36 ` Chris Wilson
2014-02-04 13:23 ` Daniel Vetter
2014-02-04 14:14 ` [PATCH] tests: Add gem_madvise Chris Wilson
2014-02-04 16:04 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204110513.GJ17001@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox