From: Damien Lespiau <damien.lespiau@intel.com>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Make infoframe trnsmission more reliable on g4x
Date: Mon, 10 Feb 2014 12:16:14 +0000 [thread overview]
Message-ID: <20140210121614.GC9282@strange.amr.corp.intel.com> (raw)
In-Reply-To: <1390511735-13677-4-git-send-email-ville.syrjala@linux.intel.com>
On Thu, Jan 23, 2014 at 11:15:35PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> On g4x there's just one video DIP, but there can be two HDMI/DVI
> ports. Currently even a DVI monitor on another port can clobber
> the infoframes meant for a real HDMI monitor on the other port.
>
> Make sure we only ever send DIPs to one port. The first port with a
> HDMI sink to get there gets to own the DIP until such time that the
> port is completely turned off (ie. not just DPMS off). If there are
> two HDMI sinks attached, the one to arrive second doesn't get any
> infoframes. And if there's a DVI sink on the other port, it will
> no longer disable DIP transmission for the other port.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
I guess follow-up patches could turn off Video DIPs on other platforms,
if I read the code correctly we're always leaving Video DIPs on when
disabling the pipe.
--
Damien
next prev parent reply other threads:[~2014-02-10 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 21:15 [PATCH 0/3] drm/i915: "Fix" g4x infoframes w/ multiple HDMI/DVI monitors ville.syrjala
2014-01-23 21:15 ` [PATCH 1/3] drm/i915: Add encoder .off() hook ville.syrjala
2014-02-10 12:10 ` Damien Lespiau
2014-01-23 21:15 ` [PATCH 2/3] drm/i915: Convert DIP port switch cases to a simple macro ville.syrjala
2014-02-10 12:11 ` Damien Lespiau
2014-02-13 9:43 ` Daniel Vetter
2014-01-23 21:15 ` [PATCH 3/3] drm/i915: Make infoframe trnsmission more reliable on g4x ville.syrjala
2014-02-10 12:16 ` Damien Lespiau [this message]
2014-02-10 12:40 ` Ville Syrjälä
2014-02-10 17:28 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210121614.GC9282@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox