From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
peter@colberg.org
Subject: Re: [PATCH] drm/i915: reverse dp link param selection, prefer fast over wide again
Date: Wed, 5 Mar 2014 19:14:47 +0100 [thread overview]
Message-ID: <20140305181447.GU17001@phenom.ffwll.local> (raw)
In-Reply-To: <87lhwrpcx0.fsf@intel.com>
On Mon, Mar 03, 2014 at 04:36:11PM +0200, Jani Nikula wrote:
> On Mon, 03 Mar 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > ... it's this time of the year again. Originally we've frobbed this to
> > fix up some regressions, but maybe our DP code improved sufficiently
> > now that we can dare to do again what the spec recommends.
> >
> > This reverts
> >
> > commit 2514bc510d0c3aadcc5204056bb440fa36845147
> > Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Date: Thu Jun 21 15:13:50 2012 -0700
> >
> > drm/i915: prefer wide & slow to fast & narrow in DP configs
> >
> > I'm pretty sure I'll regret this patch, but otoh I expect we won't
> > make progress here without poking the devil occasionally.
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> I agree we should bite the bullet and do this. This is what the DP specs
> tell us to do. I'm pretty sure there will be regressions, but I'm also
> starting to believe there's a greater number of machines that are
> currently either broken beyond repair or papered over with some hacks
> than the number that will regress. We should just dig into them and fix
> them instead of burying our heads in the sand.
Queued for -next, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-03-05 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 10:18 [PATCH] drm/i915: reverse dp link param selection, prefer fast over wide again Daniel Vetter
2014-03-03 14:36 ` Jani Nikula
2014-03-05 18:14 ` Daniel Vetter [this message]
2014-03-03 16:10 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305181447.GU17001@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=peter@colberg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox