From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH] drm/i915: fix typo in display IRQ mask when disabling IRQs
Date: Mon, 10 Mar 2014 21:50:05 +0100 [thread overview]
Message-ID: <20140310205005.GC30571@phenom.ffwll.local> (raw)
In-Reply-To: <1394473488-11179-1-git-send-email-imre.deak@intel.com>
On Mon, Mar 10, 2014 at 07:44:48PM +0200, Imre Deak wrote:
> Introduced in
> commit e0e33f8ff6f0b6d286afc314802be4993341bd47
> Author: Imre Deak <imre.deak@intel.com>
> Date: Tue Mar 4 19:23:07 2014 +0200
>
> The impact was luckily minimal, due to the extra check we do against a
> software pipestat IRQ mask.
>
> Caught by Fengguang's 0-day tester.
>
> Cc: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index be2713f..c8e262f 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3074,7 +3074,7 @@ static void valleyview_display_irqs_uninstall(struct drm_i915_private *dev_priv)
>
> iir_mask = I915_DISPLAY_PORT_INTERRUPT |
> I915_DISPLAY_PIPE_A_EVENT_INTERRUPT |
> - I915_DISPLAY_PIPE_A_EVENT_INTERRUPT;
> + I915_DISPLAY_PIPE_B_EVENT_INTERRUPT;
Oops. Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-03-10 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 17:44 [PATCH] drm/i915: fix typo in display IRQ mask when disabling IRQs Imre Deak
2014-03-10 20:50 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310205005.GC30571@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=fengguang.wu@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox