From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: move dev_priv->suspend around
Date: Wed, 12 Mar 2014 16:12:06 +0100 [thread overview]
Message-ID: <20140312151206.GL30571@phenom.ffwll.local> (raw)
In-Reply-To: <87d2hr23kg.fsf@intel.com>
On Wed, Mar 12, 2014 at 11:01:35AM +0200, Jani Nikula wrote:
> On Mon, 10 Mar 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > When adding new gunk, _always_ think of a good place. Start/end
> > usually just means that this didn't happen, and on top of that results
> > in needless conflicts with other patches doing the same.
>
> I'm a fan of unnamed structs within structs to group stuff. The .wm one
> in dev priv is a great example.
Me too, but I haven't found a suitable companion yet for this stuff ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-03-12 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 9:03 [PATCH] drm/i915: move dev_priv->suspend around Daniel Vetter
2014-03-12 9:01 ` Jani Nikula
2014-03-12 15:12 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312151206.GL30571@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox