From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: use async hpd_irq_event function on resume
Date: Wed, 21 May 2014 08:52:34 +0200 [thread overview]
Message-ID: <20140521065234.GE24095@phenom.ffwll.local> (raw)
In-Reply-To: <1400624735-4220-3-git-send-email-jbarnes@virtuousgeek.org>
On Tue, May 20, 2014 at 03:25:35PM -0700, Jesse Barnes wrote:
> Gets the detect code (which may take awhile) out of the resume path,
> speeding things up a bit.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 302495f..571f688 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -606,7 +606,7 @@ static int __i915_drm_thaw(struct drm_device *dev, bool restore_gtt_mappings)
> intel_hpd_init(dev);
> dev_priv->enable_hotplug_processing = true;
> /* Config may have changed between suspend and resume */
> - drm_helper_hpd_irq_event(dev);
> + async_schedule(drm_helper_hpd_irq_event_async, dev);
Does that really help all that much? I've thought the driver core
sychnronizes all the async workers again once resume is done. I'm better
to schedule this as a fully async work with e.g. a 1s delay, like we do
with the rps resume work.
-Daniel
> }
>
> intel_opregion_init(dev);
> --
> 1.8.4.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-05-21 6:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 22:25 [PATCH 1/3] drm/i915: drop encoder hot_plug calls at resume Jesse Barnes
2014-05-20 22:25 ` [PATCH 2/3] drm: add async version of hpd_irq_event Jesse Barnes
2014-05-21 6:50 ` Daniel Vetter
2014-05-20 22:25 ` [PATCH 3/3] drm/i915: use async hpd_irq_event function on resume Jesse Barnes
2014-05-21 6:52 ` Daniel Vetter [this message]
2014-05-21 15:00 ` Jesse Barnes
2014-05-21 15:12 ` Daniel Vetter
2014-05-21 6:53 ` [PATCH 1/3] drm/i915: drop encoder hot_plug calls at resume Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521065234.GE24095@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox