From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm: add async version of hpd_irq_event
Date: Wed, 21 May 2014 08:50:42 +0200 [thread overview]
Message-ID: <20140521065042.GD24095@phenom.ffwll.local> (raw)
In-Reply-To: <1400624735-4220-2-git-send-email-jbarnes@virtuousgeek.org>
On Tue, May 20, 2014 at 03:25:34PM -0700, Jesse Barnes wrote:
> In some cases, the callers of this function may not need the return
> value and delaying the uevent is ok. So add an async version of the
> function for use in those cases.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> drivers/gpu/drm/drm_probe_helper.c | 8 ++++++++
> include/drm/drm_crtc_helper.h | 2 ++
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
> index 79f07f2..f3aee4a 100644
> --- a/drivers/gpu/drm/drm_probe_helper.c
> +++ b/drivers/gpu/drm/drm_probe_helper.c
> @@ -446,3 +446,11 @@ bool drm_helper_hpd_irq_event(struct drm_device *dev)
> return changed;
> }
> EXPORT_SYMBOL(drm_helper_hpd_irq_event);
> +
Kerneldoc is missing.
-Daniel
> +void drm_helper_hpd_irq_event_async(void *data, async_cookie_t cookie)
> +{
> + struct drm_device *dev = data;
> +
> + drm_helper_hpd_irq_event(dev);
> +}
> +EXPORT_SYMBOL(drm_helper_hpd_irq_event_async);
> diff --git a/include/drm/drm_crtc_helper.h b/include/drm/drm_crtc_helper.h
> index a3d75fe..4f4ed9c 100644
> --- a/include/drm/drm_crtc_helper.h
> +++ b/include/drm/drm_crtc_helper.h
> @@ -33,6 +33,7 @@
> #ifndef __DRM_CRTC_HELPER_H__
> #define __DRM_CRTC_HELPER_H__
>
> +#include <linux/async.h>
> #include <linux/spinlock.h>
> #include <linux/types.h>
> #include <linux/idr.h>
> @@ -172,6 +173,7 @@ extern int drm_helper_probe_single_connector_modes_nomerge(struct drm_connector
> extern void drm_kms_helper_poll_init(struct drm_device *dev);
> extern void drm_kms_helper_poll_fini(struct drm_device *dev);
> extern bool drm_helper_hpd_irq_event(struct drm_device *dev);
> +extern void drm_helper_hpd_irq_event_async(void *data, async_cookie_t cookie);
> extern void drm_kms_helper_hotplug_event(struct drm_device *dev);
>
> extern void drm_kms_helper_poll_disable(struct drm_device *dev);
> --
> 1.8.4.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-05-21 6:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 22:25 [PATCH 1/3] drm/i915: drop encoder hot_plug calls at resume Jesse Barnes
2014-05-20 22:25 ` [PATCH 2/3] drm: add async version of hpd_irq_event Jesse Barnes
2014-05-21 6:50 ` Daniel Vetter [this message]
2014-05-20 22:25 ` [PATCH 3/3] drm/i915: use async hpd_irq_event function on resume Jesse Barnes
2014-05-21 6:52 ` Daniel Vetter
2014-05-21 15:00 ` Jesse Barnes
2014-05-21 15:12 ` Daniel Vetter
2014-05-21 6:53 ` [PATCH 1/3] drm/i915: drop encoder hot_plug calls at resume Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521065042.GD24095@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox