From: Daniel Vetter <daniel@ffwll.ch>
To: "Mateo Lozano, Oscar" <oscar.mateo@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] tests/drv_hangman: Convert test from shell script to c
Date: Thu, 22 May 2014 12:10:51 +0200 [thread overview]
Message-ID: <20140522101051.GQ14357@phenom.ffwll.local> (raw)
In-Reply-To: <92648605EABDA246B775AAB04C95A7A3012F0990@IRSMSX103.ger.corp.intel.com>
On Wed, May 21, 2014 at 03:40:15PM +0000, Mateo Lozano, Oscar wrote:
> > -----Original Message-----
> > From: Mika Kuoppala [mailto:mika.kuoppala@linux.intel.com]
> > Sent: Tuesday, May 20, 2014 12:56 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Mateo Lozano, Oscar
> > Subject: [PATCH 1/2] tests/drv_hangman: Convert test from shell script to c
> >
> > Mixing script and standlone tests didn't mix well with the strict i915_ring_stop
> > flags handling. Also squash drv_missed_irq_hang to the new test.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78322
> > Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> > ---
> > tests/Makefile.sources | 3 +-
> > tests/drv_hangman | 70 ---------
> > tests/drv_hangman.c | 357
> > +++++++++++++++++++++++++++++++++++++++++++++
> > tests/drv_missed_irq_hang | 70 ---------
>
> I am missing a tests/.gitignore entry
> Other than that: Reviewed-by: Oscar Mateo <oscar.mateo@intel.com>
The nop batch isn't good enough to reliably provoke a stall for the gpu.
Without that the missed irq test won't work. The script uses some pretty
expensive blitter workload (gem_exec_blt). Since patch 1 fixes a
regresssion I think we should just take out those subtests and keep the
missed_irq script for now so that we can push this series.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-05-22 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 11:55 [PATCH 1/2] tests/drv_hangman: Convert test from shell script to c Mika Kuoppala
2014-05-20 11:55 ` [PATCH 2/2] tests/drv_hangman: Add subtest for error state capture/dump Mika Kuoppala
2014-05-21 15:41 ` Mateo Lozano, Oscar
2014-05-21 15:40 ` [PATCH 1/2] tests/drv_hangman: Convert test from shell script to c Mateo Lozano, Oscar
2014-05-22 10:10 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522101051.GQ14357@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=oscar.mateo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox