From: Damien Lespiau <damien.lespiau@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Make intel_dsi_init() return void
Date: Tue, 3 Jun 2014 13:50:54 +0100 [thread overview]
Message-ID: <20140603125054.GC17813@strange.amr.corp.intel.com> (raw)
In-Reply-To: <87zjhufbb9.fsf@intel.com>
On Tue, Jun 03, 2014 at 03:05:14PM +0300, Jani Nikula wrote:
> > - return false;
> > + return;
>
> Okay this went in already, but I find return statements at the end of
> void functions like that a bit silly...
>
> ...but hey, you can send a fix removing that! ;)
Sigh, will do, thanks for pointed it out.
--
Damien
prev parent reply other threads:[~2014-06-03 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 11:30 [PATCH] drm/i915: Make intel_dsi_init() return void Damien Lespiau
2014-05-28 13:00 ` Daniel Vetter
2014-06-03 12:05 ` Jani Nikula
2014-06-03 12:50 ` Damien Lespiau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603125054.GC17813@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox