From: Ben Widawsky <ben@bwidawsk.net>
To: Wendy Wang <wendy.wang@intel.com>
Cc: intel-gfx@lists.freedesktop.org, "Liu,
Lei A" <lei.a.liu@intel.com>,
benjamin.widawsky@intel.com
Subject: Re: [PATCH] [I-G-T]Add rc6_residency_counter subtest
Date: Thu, 5 Jun 2014 10:19:12 -0700 [thread overview]
Message-ID: <20140605171912.GA7913@bwidawsk.net> (raw)
In-Reply-To: <1401935262-23220-1-git-send-email-wendy.wang@intel.com>
On Thu, Jun 05, 2014 at 10:27:42AM +0800, Wendy Wang wrote:
> Move rc6_residency_check to subtest, add new rc6_residency_counter subtest
> for pm_rc6_residency IGT case.
>
Looks good to me. You have some formatting issues:
for loops don't use the right coding style
useless comment to fopen
bad sign-off in mail
added unnecessary whitespace
replace assert with open coded abort
So I've merged it with all those warts (except I fixed the
signed-off-by). Please keep these things in mind next patch, and feel
free to submit patches to fix these issues as well.
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-06-05 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 2:27 [PATCH] [I-G-T]Add rc6_residency_counter subtest Wendy Wang
2014-06-05 9:01 ` Daniel Vetter
2014-06-05 17:19 ` Ben Widawsky [this message]
2014-06-05 19:16 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605171912.GA7913@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lei.a.liu@intel.com \
--cc=wendy.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox