From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs
Date: Fri, 13 Jun 2014 09:31:42 -0700 [thread overview]
Message-ID: <20140613093142.156fb003@jbarnes-desktop> (raw)
In-Reply-To: <20140613160210.GL6451@nuc-i3427.alporthouse.com>
On Fri, 13 Jun 2014 17:02:10 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, Jun 13, 2014 at 06:54:02PM +0300, Ville Syrjälä wrote:
> > On Fri, Jun 13, 2014 at 08:32:38AM -0700, Jesse Barnes wrote:
> > > Early revs didn't have PPGTT support, so disable there.
> > >
> > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
> > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > ---
> > > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > > index 8b3cde7..01287d9 100644
> > > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > > @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
> > > }
> > > #endif
> > >
> > > + /* Early VLV doesn't have this */
> > > + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc)
> >
> > Did you mean < 0xb?
>
> Also some log message is required.
Ok, added.
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-06-13 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 15:32 [PATCH] drm/i915/vlv: disable PPGTT on early revs Jesse Barnes
2014-06-13 15:54 ` Ville Syrjälä
2014-06-13 16:02 ` Chris Wilson
2014-06-13 16:31 ` Jesse Barnes [this message]
2014-06-13 16:09 ` Jesse Barnes
2014-06-13 16:16 ` [PATCH] drm/i915/vlv: disable PPGTT on early revs v2 Jesse Barnes
2014-06-13 16:28 ` [PATCH] drm/i915/vlv: disable PPGTT on early revs v3 Jesse Barnes
2014-06-13 16:45 ` Ville Syrjälä
2014-06-13 16:52 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613093142.156fb003@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox