From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs v3
Date: Fri, 13 Jun 2014 18:52:48 +0200 [thread overview]
Message-ID: <20140613165248.GU5821@phenom.ffwll.local> (raw)
In-Reply-To: <20140613164550.GC27580@intel.com>
On Fri, Jun 13, 2014 at 07:45:50PM +0300, Ville Syrjälä wrote:
> On Fri, Jun 13, 2014 at 09:28:33AM -0700, Jesse Barnes wrote:
> > Early revs didn't have PPGTT support, so disable there.
> >
> > v2: add debug msg when disabling on early stepping
> > v3: enable on other B3 packages as well (untested) (Ville)
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> I don't have any affected systems myself, but it did fail for me on
> a pre-production part and the evidence from the bugs is strong, so:
>
> Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Queued for -next, thanks for the patch.
-Daniel
>
> > ---
> > drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > index 8b3cde7..7f226fa 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > @@ -63,6 +63,12 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
> > }
> > #endif
> >
> > + /* Early VLV doesn't have this */
> > + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xb) {
> > + DRM_DEBUG_DRIVER("disabling PPGTT on pre-B3 step VLV\n");
> > + return 0;
> > + }
> > +
> > return HAS_ALIASING_PPGTT(dev) ? 1 : 0;
> > }
> >
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-06-13 16:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 15:32 [PATCH] drm/i915/vlv: disable PPGTT on early revs Jesse Barnes
2014-06-13 15:54 ` Ville Syrjälä
2014-06-13 16:02 ` Chris Wilson
2014-06-13 16:31 ` Jesse Barnes
2014-06-13 16:09 ` Jesse Barnes
2014-06-13 16:16 ` [PATCH] drm/i915/vlv: disable PPGTT on early revs v2 Jesse Barnes
2014-06-13 16:28 ` [PATCH] drm/i915/vlv: disable PPGTT on early revs v3 Jesse Barnes
2014-06-13 16:45 ` Ville Syrjälä
2014-06-13 16:52 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613165248.GU5821@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox