From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Rodrigo Vivi <rodrigo.vivi@gmail.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 04/15] drm/i915: Run psr_setup unconditionally
Date: Tue, 17 Jun 2014 09:23:48 +0200 [thread overview]
Message-ID: <20140617072348.GO5821@phenom.ffwll.local> (raw)
In-Reply-To: <20140617064353.GB17744@nuc-i3427.alporthouse.com>
On Tue, Jun 17, 2014 at 07:43:53AM +0100, Chris Wilson wrote:
> On Mon, Jun 16, 2014 at 05:03:02PM -0700, Rodrigo Vivi wrote:
> > On Mon, Jun 16, 2014 at 10:51 AM, Daniel Vetter
> > <[1]daniel.vetter@ffwll.ch> wrote:
> >
> > static void intel_edp_psr_enable_sink(struct intel_dp *intel_dp)
> > @@ -1911,9 +1906,6 @@ void intel_edp_psr_exit(struct drm_device *dev,
> > bool schedule_back)
> > if (!HAS_PSR(dev))
> > return;
>
> Whilst you are here, this should just be a if (dev_priv->psr.enabled)
> check.
I have fixup for psr_invalidate/psr_flush, as this ends up being called to
do exactly that. It blew up ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-06-17 7:23 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 17:51 [PATCH 00/15] Accurate frontbuffer tracking and psr conversion Daniel Vetter
2014-06-16 17:51 ` [PATCH 01/15] drm/i915: Add missing statics to recent psr functions Daniel Vetter
2014-06-16 23:57 ` Rodrigo Vivi
2014-06-17 8:22 ` Daniel Vetter
2014-06-16 17:51 ` [PATCH 02/15] drm/i915: Drop unecessary complexity from psr_inactivate Daniel Vetter
2014-06-16 23:58 ` Rodrigo Vivi
2014-06-16 17:51 ` [PATCH 03/15] drm/i915: Ditch intel_edp_psr_update Daniel Vetter
2014-06-17 0:00 ` Rodrigo Vivi
2014-06-16 17:51 ` [PATCH 04/15] drm/i915: Run psr_setup unconditionally Daniel Vetter
2014-06-17 0:03 ` Rodrigo Vivi
2014-06-17 6:43 ` Chris Wilson
2014-06-17 7:23 ` Daniel Vetter [this message]
2014-06-17 8:26 ` Daniel Vetter
2014-06-16 17:51 ` [PATCH 05/15] drm/i915: Drop schedule_back from psr_exit Daniel Vetter
2014-06-17 0:06 ` Rodrigo Vivi
2014-06-17 7:25 ` Daniel Vetter
2014-06-16 17:51 ` [PATCH 06/15] drm/i915: Add a FIXME about drrs/psr interactions Daniel Vetter
2014-06-16 17:51 ` [PATCH 07/15] drm/i915: Track the psr dp connector in dev_priv->psr.enabled Daniel Vetter
2014-06-17 0:10 ` Rodrigo Vivi
2014-06-17 7:26 ` Daniel Vetter
2014-06-16 17:51 ` [PATCH 08/15] drm/i915: Don't try to disable psr harder from the work item Daniel Vetter
2014-06-17 0:20 ` Rodrigo Vivi
2014-06-17 7:29 ` Daniel Vetter
2014-06-16 17:51 ` [PATCH 09/15] drm/i915: Lock down psr sw/hw state tracking Daniel Vetter
2014-06-16 17:51 ` [PATCH 10/15] drm/i915: More checks for psr.enabled Daniel Vetter
2014-06-16 17:51 ` [PATCH 11/15] drm/i915: Add locking to psr code Daniel Vetter
2014-06-16 17:51 ` [PATCH 12/15] drm/i915: Introduce accurate frontbuffer tracking Daniel Vetter
2014-06-16 17:51 ` [PATCH 13/15] drm/i915: Use new frontbuffer bits to increase pll clock Daniel Vetter
2014-06-16 17:51 ` [PATCH 14/15] drm/i915: Track frontbuffer invalidation/flushing Daniel Vetter
2014-06-17 6:41 ` Chris Wilson
2014-06-17 7:32 ` Daniel Vetter
2014-06-17 7:36 ` Chris Wilson
2014-06-17 9:01 ` Daniel Vetter
2014-06-17 6:46 ` Chris Wilson
2014-06-17 7:33 ` Daniel Vetter
2014-06-17 6:49 ` Chris Wilson
2014-06-17 7:36 ` Daniel Vetter
2014-06-17 6:50 ` Chris Wilson
2014-06-17 7:37 ` Daniel Vetter
2014-06-17 7:40 ` Chris Wilson
2014-06-17 7:42 ` Chris Wilson
2014-06-17 6:52 ` Chris Wilson
2014-06-17 7:39 ` Daniel Vetter
2014-06-17 6:54 ` Chris Wilson
2014-06-17 7:45 ` Daniel Vetter
2014-06-17 7:53 ` Chris Wilson
2014-06-17 9:17 ` Daniel Vetter
2014-06-17 6:57 ` Chris Wilson
2014-06-17 7:48 ` Daniel Vetter
2014-06-17 7:55 ` Chris Wilson
2014-06-17 7:00 ` Chris Wilson
2014-06-17 7:52 ` Daniel Vetter
2014-06-17 8:10 ` Chris Wilson
2014-06-17 9:33 ` Daniel Vetter
2014-06-17 9:42 ` Chris Wilson
2014-06-17 9:54 ` Daniel Vetter
2014-06-17 10:00 ` Chris Wilson
2014-06-16 17:51 ` [PATCH 15/15] drm/i915: Fix up PSR frontbuffer tracking Daniel Vetter
2014-06-17 7:02 ` Chris Wilson
2014-06-17 8:06 ` Daniel Vetter
2014-06-17 7:07 ` Chris Wilson
2014-06-17 8:08 ` Daniel Vetter
2014-06-16 19:37 ` [PATCH 00/15] Accurate frontbuffer tracking and psr conversion Chris Wilson
2014-06-16 20:37 ` Daniel Vetter
2014-06-17 7:09 ` Chris Wilson
2014-06-17 9:30 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617072348.GO5821@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox