From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915: Don't cast a pointer to void* unnecessarily
Date: Thu, 10 Jul 2014 22:26:06 +0200 [thread overview]
Message-ID: <20140710202606.GL17271@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGSmGbnu5GD+=1u9kUzs7GQOR59q7m0EeaTwsJyqXCTEtg@mail.gmail.com>
On Thu, Jul 10, 2014 at 04:26:53PM -0300, Paulo Zanoni wrote:
> 2014-07-10 10:52 GMT-03:00 Damien Lespiau <damien.lespiau@intel.com>:
> > C is super happy to asign anything pointer to void *. Don't pretend
> > otherwise.
>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Queued for -next, thanks for the patch.
-Daniel
>
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_dma.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> > index ce69185..2c0bad6 100644
> > --- a/drivers/gpu/drm/i915/i915_dma.c
> > +++ b/drivers/gpu/drm/i915/i915_dma.c
> > @@ -1596,7 +1596,7 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)
> > if (dev_priv == NULL)
> > return -ENOMEM;
> >
> > - dev->dev_private = (void *)dev_priv;
> > + dev->dev_private = dev_priv;
> > dev_priv->dev = dev;
> >
> > /* copy initial configuration to dev_priv->info */
> > --
> > 1.8.3.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
> --
> Paulo Zanoni
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-07-10 20:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 13:52 [PATCH 1/2] drm/i915: Make the device_info structure __initconst Damien Lespiau
2014-07-10 13:52 ` [PATCH 2/2] drm/i915: Don't cast a pointer to void* unnecessarily Damien Lespiau
2014-07-10 19:26 ` Paulo Zanoni
2014-07-10 20:26 ` Daniel Vetter [this message]
2014-07-10 19:18 ` [PATCH 1/2] drm/i915: Make the device_info structure __initconst Paulo Zanoni
2014-07-10 20:25 ` Daniel Vetter
2014-07-10 21:47 ` Damien Lespiau
2014-07-11 6:33 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710202606.GL17271@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox