Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt
Date: Tue, 26 Aug 2014 12:10:56 -0700	[thread overview]
Message-ID: <20140826121056.2578275a@jbarnes-desktop> (raw)
In-Reply-To: <53FCD9EF.3060406@hartkopp.net>

On Tue, 26 Aug 2014 21:03:11 +0200
Oliver Hartkopp <socketcan@hartkopp.net> wrote:

> On 26.08.2014 20:52, Jesse Barnes wrote:
> > On Tue, 26 Aug 2014 09:23:54 +0200
> > Daniel Vetter <daniel@ffwll.ch> wrote:
> 
> >>> This happens in irq_postinstall before we've set the pm._irqs_disabled flag,
> >>> but shouldn't warn.  So add a nowarn variant to allow this to happen w/o
> >>> a backtrace and keep the rest of the IRQ tracking code happy.
> >>>
> 
> >> Also the commit message is a bit thin on the usual details like which
> >> commits introduced this regression, so that maintainers know where to
> >> apply this to.
> > 
> > I don't have the commit...  Oliver do you have it handy?
> > 
> 
> Hm - I really can not tell what has been done to introduce this regression.
> I just saw the warning on my machine after upgrading to 3.17 ...
> 
> You can ask me about linux/net/can/ but not the drm stuff ;-)

I think it was this one Daniel, or the combination of patches around it:

commit 95f25beddba2ec9510b249740bacc11eca70cf75
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Fri Jun 20 09:29:22 2014 -0700

    drm/i915: set pm._irqs_disabled at IRQ init time


-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2014-08-26 19:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 23:24 [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt Jesse Barnes
2014-08-26  5:26 ` Oliver Hartkopp
2014-08-26  7:23 ` Daniel Vetter
2014-08-26 18:52   ` Jesse Barnes
2014-08-26 19:03     ` Oliver Hartkopp
2014-08-26 19:10       ` Jesse Barnes [this message]
2014-08-26 20:51     ` Daniel Vetter
2014-08-26 21:18       ` Jesse Barnes
2014-08-26 21:33         ` Daniel Vetter
2014-08-27  6:30       ` Oliver Hartkopp
2014-08-27 19:59       ` Jesse Barnes
2014-08-27 21:33         ` Daniel Vetter
2014-08-27 21:36           ` Jesse Barnes
2014-08-29  7:08         ` Sun, Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140826121056.2578275a@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox