From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt
Date: Wed, 27 Aug 2014 14:36:21 -0700 [thread overview]
Message-ID: <20140827143621.512a4be1@jbarnes-desktop> (raw)
In-Reply-To: <CAKMK7uHT9TcQJbkhO9Eza-oau3QOznnwf+PJBHLW4O2swL1Cig@mail.gmail.com>
On Wed, 27 Aug 2014 23:33:05 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Aug 27, 2014 at 9:59 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > Yi, can you get this one run through testing on multiple platforms? We
> > just want to make sure there's not some path we missed that's gonna
> > spew a warning with this change.
>
> I think that amount of testing is totally out of balance to keep a
> rather tiny warninig alive in the driver load code. The major use for
> the pm._irqs_disabled is to catch runtime pm bugs where code uses
> changes irq settings while the chip is off. That part will still be
> 100% effective with Jesse's patch.
>
> So I recommended that we instead merge Jesses patch instead of mine
> for -fixes. Jesse's patch has my r-b fwiw.
Either is fine with me. Maybe you could cc the PRTS and see if it
gives you results!
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-08-27 21:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 23:24 [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt Jesse Barnes
2014-08-26 5:26 ` Oliver Hartkopp
2014-08-26 7:23 ` Daniel Vetter
2014-08-26 18:52 ` Jesse Barnes
2014-08-26 19:03 ` Oliver Hartkopp
2014-08-26 19:10 ` Jesse Barnes
2014-08-26 20:51 ` Daniel Vetter
2014-08-26 21:18 ` Jesse Barnes
2014-08-26 21:33 ` Daniel Vetter
2014-08-27 6:30 ` Oliver Hartkopp
2014-08-27 19:59 ` Jesse Barnes
2014-08-27 21:33 ` Daniel Vetter
2014-08-27 21:36 ` Jesse Barnes [this message]
2014-08-29 7:08 ` Sun, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827143621.512a4be1@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox