From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Don't reinit hpd interrupts after gpu reset
Date: Tue, 9 Sep 2014 17:14:22 +0200 [thread overview]
Message-ID: <20140909151422.GL15520@phenom.ffwll.local> (raw)
In-Reply-To: <20140909130315.GG4193@intel.com>
On Tue, Sep 09, 2014 at 04:03:15PM +0300, Ville Syrjälä wrote:
> On Mon, Sep 08, 2014 at 06:17:18PM +0200, Daniel Vetter wrote:
> > Somehow I've overlooked this when simplifying the irq reinit
> > scheme on gen4.5+ in
> >
> > commit 78ad455fd229c6f6cc2f390ccbe0d8f1a62d55a9
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date: Thu May 22 22:18:21 2014 +0200
> >
> > drm/i915: Improve irq handling after gpu resets
> >
> > Since display interrups in general survive a gpu reset on those
> > platforms there's also no need to reinit the hotplug settings.
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> This matches my observations on actual hardware. IIRC I looked at the
> reset vs. interrupt registers at least on ILK and IVB and the registers
> retained their current values on both.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-09-09 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 16:17 [PATCH] drm/i915: Don't reinit hpd interrupts after gpu reset Daniel Vetter
2014-09-09 13:03 ` Ville Syrjälä
2014-09-09 15:14 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909151422.GL15520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox