From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't spam dmesg with rps messages on vlv/chv
Date: Mon, 29 Sep 2014 16:54:05 +0200 [thread overview]
Message-ID: <20140929145405.GU4109@phenom.ffwll.local> (raw)
In-Reply-To: <8761h6i4dn.fsf@intel.com>
On Tue, Sep 02, 2014 at 03:38:44PM +0300, Jani Nikula wrote:
> On Tue, 02 Sep 2014, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > If the GPU frequency isn't going to change don't spam dmesg with
> > debug messages about it.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Oh yes please!
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Queued for -next-fixes, thanks for the patch.
-Daniel
>
>
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 78e39f8..9bc44f0 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -3488,17 +3488,18 @@ void valleyview_set_rps(struct drm_device *dev, u8 val)
> > WARN_ON(val > dev_priv->rps.max_freq_softlimit);
> > WARN_ON(val < dev_priv->rps.min_freq_softlimit);
> >
> > - DRM_DEBUG_DRIVER("GPU freq request from %d MHz (%u) to %d MHz (%u)\n",
> > - vlv_gpu_freq(dev_priv, dev_priv->rps.cur_freq),
> > - dev_priv->rps.cur_freq,
> > - vlv_gpu_freq(dev_priv, val), val);
> > -
> > if (WARN_ONCE(IS_CHERRYVIEW(dev) && (val & 1),
> > "Odd GPU freq value\n"))
> > val &= ~1;
> >
> > - if (val != dev_priv->rps.cur_freq)
> > + if (val != dev_priv->rps.cur_freq) {
> > + DRM_DEBUG_DRIVER("GPU freq request from %d MHz (%u) to %d MHz (%u)\n",
> > + vlv_gpu_freq(dev_priv, dev_priv->rps.cur_freq),
> > + dev_priv->rps.cur_freq,
> > + vlv_gpu_freq(dev_priv, val), val);
> > +
> > vlv_punit_write(dev_priv, PUNIT_REG_GPU_FREQ_REQ, val);
> > + }
> >
> > I915_WRITE(GEN6_PMINTRMSK, gen6_rps_pm_mask(dev_priv, val));
> >
> > --
> > 1.8.5.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-09-29 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 12:12 [PATCH] drm/i915: Don't spam dmesg with rps messages on vlv/chv ville.syrjala
2014-09-02 12:38 ` Jani Nikula
2014-09-29 14:54 ` Daniel Vetter [this message]
2014-09-02 12:45 ` Chris Wilson
2014-09-02 13:17 ` Ville Syrjälä
2014-09-02 13:46 ` Ville Syrjälä
2014-09-02 13:50 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929145405.GU4109@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox