From: Damien Lespiau <damien.lespiau@intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/6] tools/null_state_gen: Add GEN9 golden context batch buffer creation
Date: Fri, 10 Oct 2014 13:03:32 +0100 [thread overview]
Message-ID: <20141010120332.GA5340@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1412873679-7895-6-git-send-email-mika.kuoppala@intel.com>
On Thu, Oct 09, 2014 at 07:54:39PM +0300, Mika Kuoppala wrote:
> From: Armin Reese <armin.c.reese@intel.com>
>
> Modifications to 'null_state_gen' so it can generate GEN9
> golden context batch buffer source for SKL.
>
> v2: - rebased on top of gen8 changes (Mika)
> - fixed state base address command size (Mika)
> - base address size macro as pages (Mika)
>
> v3: - rebased on top of current master (Mika)
> - removed obsolete #includes (Mika)
> - added copyright (Mika)
> - render and component packing added (Mika)
>
> Cc: Damien Lespiau <damien.lespiau@intel.com>
> Cc: Armin Reese <armin.c.reese@intel.com>
> Cc: Volkin, Bradley D <bradley.d.volkin@intel.com>
> Signed-off-by: Armin Reese <armin.c.reese@intel.com> (v1)
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
Hi,
This looks really good, I think we should just push it. There was a
suggestion to make the null state generator output the copyright notice
along with the generated file as well, but that can be done whenever.
--
Damien
next prev parent reply other threads:[~2014-10-10 12:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 16:54 [PATCH 1/6] tools/null_state_gen: Add copyrights Mika Kuoppala
2014-10-09 16:54 ` [PATCH 2/6] tools/null_state_gen: Add more debug output Mika Kuoppala
2014-10-09 16:54 ` [PATCH 3/6] tools/null_state_gen: Limit the total state len to 4096 bytes Mika Kuoppala
2014-10-09 16:54 ` [PATCH 4/6] tools/null_state_gen: Add macro to emit commands with null state Mika Kuoppala
2014-10-09 16:54 ` [PATCH 5/6] tools/null_state_gen: Add Gen8 golden state Mika Kuoppala
2014-10-09 16:54 ` [PATCH 6/6] tools/null_state_gen: Add GEN9 golden context batch buffer creation Mika Kuoppala
2014-10-10 12:03 ` Damien Lespiau [this message]
2014-10-10 14:35 ` [PATCH] tools/null_state_gen: Add copyright notice to state output Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010120332.GA5340@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox