From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] lib: fix #define max
Date: Thu, 23 Oct 2014 14:19:49 +0200 [thread overview]
Message-ID: <20141023121948.GI26941@phenom.ffwll.local> (raw)
In-Reply-To: <87h9ywgdl4.fsf@intel.com>
On Wed, Oct 22, 2014 at 09:32:23PM +0300, Jani Nikula wrote:
> On Tue, 21 Oct 2014, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
> > Regression from:
> >
> > commit be4710a541b517b5f8663448bffed5656d59b47b
> > Author: Thomas Wood <thomas.wood@intel.com>
> > Date: Fri Oct 10 11:20:35 2014 +0100
> >
> > lib: add common min and max macros
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85218
> > Tested-by: Guo Jinxian <jinxianx.guo@intel.com>
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> Push it already!
To clarify igt process: If you're patch has been sitting on the m-l for a
day or so without objection, just push it. If it's critical (like this
one) and you're confident it's good push right after sending.
Submitting to intel-gfx for igt patches is mostly so that other people can
watch what flies by and drop suggestions for later improvements. And of
course new contributors get the full review treatment to make sure they
use all the nice stuff the testsuite provides properly.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-10-23 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 15:49 [PATCH] lib: fix #define max Mika Kuoppala
2014-10-22 18:32 ` Jani Nikula
2014-10-23 12:19 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-21 13:31 Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023121948.GI26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox