From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Correctly reject invalid flags for wait_ioctl
Date: Thu, 23 Oct 2014 16:12:03 +0200 [thread overview]
Message-ID: <20141023141203.GN26941@phenom.ffwll.local> (raw)
In-Reply-To: <20141023133941.GD10367@strange.ger.corp.intel.com>
On Thu, Oct 23, 2014 at 02:39:41PM +0100, Damien Lespiau wrote:
> On Thu, Oct 23, 2014 at 03:28:24PM +0200, Daniel Vetter wrote:
> > On Mon, Sep 29, 2014 at 3:31 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > > Not having checks for this isn't good.
> > >
> > > I've checked igt and libdrm and they all already clear flags properly.
> > > So we're lucky and should be able to sneak this ABI clarification in.
> > >
> > > Testcase: igt/gem_wait/invalid-flags
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85280
> >
> > Some please review this little fix?
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Thanks for the mercy ;-) Patch merged to dinq now.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-10-23 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 13:31 [PATCH] drm/i915: Correctly reject invalid flags for wait_ioctl Daniel Vetter
2014-10-23 13:28 ` Daniel Vetter
2014-10-23 13:39 ` Damien Lespiau
2014-10-23 14:12 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023141203.GN26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox