From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: save/restore GMBUS freq across suspend/resume on gen4
Date: Mon, 15 Dec 2014 10:11:35 +0100 [thread overview]
Message-ID: <20141215091134.GH27182@phenom.ffwll.local> (raw)
In-Reply-To: <20141210203537.GH10649@intel.com>
On Wed, Dec 10, 2014 at 10:35:37PM +0200, Ville Syrjälä wrote:
> On Wed, Dec 10, 2014 at 12:16:05PM -0800, Jesse Barnes wrote:
> > Should probably just init this in the GMbus code all the time, based on
> > the cdclk and HPLL like we do on newer platforms. Ville has code for
> > that in a rework branch, but until then we can fix this bug fairly
> > easily.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=76301
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> My cdclk extraction code doesn't seem to agree with this register for
> this particular bug reporter at least. So I think I need to go double
> check my code. The other options are that GMBUS clock isn't derived from
> cdclk on that platform, or that the HPLL/cdclk bits in configdb are
> simply not valid for this particular chipset.
>
> In the meantime however, we can at least get some machines working with
> this patch. I'm not entirely sure which platforms have this register,
> but IS_GEN4() looks safe enough since my 946GZ has it and the reporter
> has a G41.
Yeah I really don't like the save/restore_state functions since they just
bash registers without any regard to ordering constraints and stuff. I
guess your cdclk series will address this? - At least we have the
vlv_update_cdclk sprinkled all over already, probably better to call the
intel_i2c_update_cdlk and move it to intel_i2c.c, too.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-15 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 20:16 [PATCH] drm/i915: save/restore GMBUS freq across suspend/resume on gen4 Jesse Barnes
2014-12-10 20:35 ` Ville Syrjälä
2014-12-10 20:37 ` Jesse Barnes
2014-12-11 13:41 ` Jani Nikula
2014-12-15 9:11 ` Daniel Vetter [this message]
2014-12-11 6:38 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215091134.GH27182@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox