From: Damien Lespiau <damien.lespiau@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/bdw: WaGttCachingOffByDefault: bdw
Date: Mon, 8 Jun 2015 20:20:48 +0100 [thread overview]
Message-ID: <20150608192048.GB22895@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1433545103-11618-2-git-send-email-rodrigo.vivi@intel.com>
On Fri, Jun 05, 2015 at 03:58:23PM -0700, Rodrigo Vivi wrote:
> Due to RTL Bug, GAM does not support enabling GTT cache when
> big pages are also turned on. This leads to GAM reporting
> incorrect data and address.
We don't use big pages, so we can leave GTT caching enabled until we
support them (which may be never?).
--
Damien
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 3 +++
> drivers/gpu/drm/i915/intel_pm.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 0f72c0e..13474f3 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -157,6 +157,9 @@
> #define GEN8_RPCS_EU_MIN_SHIFT 0
> #define GEN8_RPCS_EU_MIN_MASK (0xf << GEN8_RPCS_EU_MIN_SHIFT)
>
> +#define GEN8_GTT_CACHE_EN 0x4024
> +#define GEN8_GTT_CACHE_DEFAULT 0xf0007fff
> +
> #define GAM_ECOCHK 0x4090
> #define BDW_DISABLE_HDC_INVALIDATION (1<<25)
> #define ECOCHK_SNB_BIT (1<<10)
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index b0fd5ec..dbb7059 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -6285,6 +6285,9 @@ static void haswell_init_clock_gating(struct drm_device *dev)
> I915_WRITE(CHICKEN_PAR1_1,
> I915_READ(CHICKEN_PAR1_1) | FORCE_ARB_IDLE_PLANES);
>
> + /* WaGttCachingOffByDefault:bdw */
> + I915_WRITE(GEN8_GTT_CACHE_EN, GEN8_GTT_CACHE_DEFAULT);
> +
> lpt_init_clock_gating(dev);
> }
>
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-08 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 22:58 [PATCH 1/2] drm/i915: PPGTT Cacheability Override Rodrigo Vivi
2015-06-05 22:58 ` [PATCH 2/2] drm/i915/bdw: WaGttCachingOffByDefault: bdw Rodrigo Vivi
2015-06-06 13:21 ` shuang.he
2015-06-08 19:20 ` Damien Lespiau [this message]
2015-06-09 9:20 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608192048.GB22895@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox