From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Update HAS_PSR macro to include all gen>=8 platforms
Date: Tue, 21 Jul 2015 11:47:52 +0200 [thread overview]
Message-ID: <20150721094752.GH16722@phenom.ffwll.local> (raw)
In-Reply-To: <20150721093119.GA15920@strange.ger.corp.intel.com>
On Tue, Jul 21, 2015 at 10:31:19AM +0100, Damien Lespiau wrote:
> On Tue, Jul 21, 2015 at 02:48:31PM +0530, Sonika Jindal wrote:
> > This is to get PSR support for bxt.
> >
> > Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
>
> Maybe with a drm/i915/bxt prefix:
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Is this actually tested? Can we maybe enable psr by default (Rodrigo seems
so close ...)?
-Daniel
>
> --
> Damien
>
> > ---
> > drivers/gpu/drm/i915/i915_drv.h | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index 718170c..54d2729 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2537,9 +2537,8 @@ struct drm_i915_cmd_table {
> >
> > #define HAS_DDI(dev) (INTEL_INFO(dev)->has_ddi)
> > #define HAS_FPGA_DBG_UNCLAIMED(dev) (INTEL_INFO(dev)->has_fpga_dbg)
> > -#define HAS_PSR(dev) (IS_HASWELL(dev) || IS_BROADWELL(dev) || \
> > - IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev) || \
> > - IS_SKYLAKE(dev))
> > +#define HAS_PSR(dev) (IS_HASWELL(dev) || IS_VALLEYVIEW(dev) || \
> > + INTEL_INFO(dev)->gen >= 8)
> > #define HAS_RUNTIME_PM(dev) (IS_GEN6(dev) || IS_HASWELL(dev) || \
> > IS_BROADWELL(dev) || IS_VALLEYVIEW(dev) || \
> > IS_SKYLAKE(dev))
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-21 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 9:18 [PATCH] drm/i915: Update HAS_PSR macro to include all gen>=8 platforms Sonika Jindal
2015-07-21 9:31 ` Damien Lespiau
2015-07-21 9:47 ` Daniel Vetter [this message]
2015-08-11 4:30 ` Jindal, Sonika
2015-08-11 9:25 ` Daniel Vetter
2015-07-22 9:36 ` [PATCH] drm/i915/bxt: " Sonika Jindal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721094752.GH16722@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox