public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/5] drm/i915: shrinker_control->nr_to_scan is now unsigned long
Date: Tue, 6 Oct 2015 14:53:21 +0200	[thread overview]
Message-ID: <20151006125321.GS3383@phenom.ffwll.local> (raw)
In-Reply-To: <1443698309-28038-1-git-send-email-chris@chris-wilson.co.uk>

On Thu, Oct 01, 2015 at 12:18:25PM +0100, Chris Wilson wrote:
> As the shrinker_control now passes us unsigned long targets, update our
> shrinker functions to match.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Queued for -next, thanks for the patch.
-Daniel

> ---
>  drivers/gpu/drm/i915/i915_drv.h          | 2 +-
>  drivers/gpu/drm/i915/i915_gem_shrinker.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index ec731e6db126..6c807c584d59 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -3155,7 +3155,7 @@ i915_gem_object_create_stolen_for_preallocated(struct drm_device *dev,
>  
>  /* i915_gem_shrinker.c */
>  unsigned long i915_gem_shrink(struct drm_i915_private *dev_priv,
> -			      long target,
> +			      unsigned long target,
>  			      unsigned flags);
>  #define I915_SHRINK_PURGEABLE 0x1
>  #define I915_SHRINK_UNBOUND 0x2
> diff --git a/drivers/gpu/drm/i915/i915_gem_shrinker.c b/drivers/gpu/drm/i915/i915_gem_shrinker.c
> index f6ecbda2c604..b627d07fad29 100644
> --- a/drivers/gpu/drm/i915/i915_gem_shrinker.c
> +++ b/drivers/gpu/drm/i915/i915_gem_shrinker.c
> @@ -73,7 +73,7 @@ static bool mutex_is_locked_by(struct mutex *mutex, struct task_struct *task)
>   */
>  unsigned long
>  i915_gem_shrink(struct drm_i915_private *dev_priv,
> -		long target, unsigned flags)
> +		unsigned long target, unsigned flags)
>  {
>  	const struct {
>  		struct list_head *list;
> @@ -159,7 +159,7 @@ i915_gem_shrink(struct drm_i915_private *dev_priv,
>  unsigned long i915_gem_shrink_all(struct drm_i915_private *dev_priv)
>  {
>  	i915_gem_evict_everything(dev_priv->dev);
> -	return i915_gem_shrink(dev_priv, LONG_MAX,
> +	return i915_gem_shrink(dev_priv, -1UL,
>  			       I915_SHRINK_BOUND | I915_SHRINK_UNBOUND);
>  }
>  
> -- 
> 2.6.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2015-10-06 12:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01 11:18 [PATCH 1/5] drm/i915: shrinker_control->nr_to_scan is now unsigned long Chris Wilson
2015-10-01 11:18 ` [PATCH 2/5] drm/i915: Add a tracepoint for the shrinker Chris Wilson
2015-10-06 12:54   ` Daniel Vetter
2015-10-06 13:16     ` Chris Wilson
2015-10-07 13:45       ` Daniel Vetter
2015-10-01 11:18 ` [PATCH 3/5] drm/i915: During shrink_all we only need to idle the GPU Chris Wilson
2015-10-06 13:00   ` Daniel Vetter
2015-10-06 13:12     ` Chris Wilson
2015-10-01 11:18 ` [PATCH 4/5] drm/i915: Remove dead i915_gem_evict_everything() Chris Wilson
2015-10-01 11:18 ` [PATCH 5/5] drm/i915: Avoid GPU stalls from kswapd Chris Wilson
2015-10-06 13:01   ` Daniel Vetter
2015-10-06 13:18     ` Chris Wilson
2015-10-07 13:51       ` Daniel Vetter
2015-10-06 12:53 ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151006125321.GS3383@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox