From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel@ffwll.ch>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/i915: Avoid GPU stalls from kswapd
Date: Wed, 7 Oct 2015 15:51:58 +0200 [thread overview]
Message-ID: <20151007135158.GE3383@phenom.ffwll.local> (raw)
In-Reply-To: <20151006131834.GT26237@nuc-i3427.alporthouse.com>
On Tue, Oct 06, 2015 at 02:18:34PM +0100, Chris Wilson wrote:
> On Tue, Oct 06, 2015 at 03:01:45PM +0200, Daniel Vetter wrote:
> > On Thu, Oct 01, 2015 at 12:18:29PM +0100, Chris Wilson wrote:
> > > Exclude active GPU pages from the purview of the background shrinker
> > > (kswapd), as these cause uncontrollable GPU stalls. Given that the
> > > shrinker is rerun until the freelists are satisfied, we should have
> > > opportunity in subsequent passes to recover the pages once idle. If the
> > > machine does run out of memory entirely, we have the forced idling in the
> > > oom-notifier as a means of releasing all the pages we can before an oom
> > > is prematurely executed.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> >
> > lgtm, but imo we should move the retire_requests from an earlier patch to
> > this one.
>
> I am not convinced. The retire_requests are there for their own reasons
> (to cover up cracks elsewhere) and not because we need them for retiring
> active objects.
Ok pulled in all of them, with notes added for the patches where I had
questions.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-07 13:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 11:18 [PATCH 1/5] drm/i915: shrinker_control->nr_to_scan is now unsigned long Chris Wilson
2015-10-01 11:18 ` [PATCH 2/5] drm/i915: Add a tracepoint for the shrinker Chris Wilson
2015-10-06 12:54 ` Daniel Vetter
2015-10-06 13:16 ` Chris Wilson
2015-10-07 13:45 ` Daniel Vetter
2015-10-01 11:18 ` [PATCH 3/5] drm/i915: During shrink_all we only need to idle the GPU Chris Wilson
2015-10-06 13:00 ` Daniel Vetter
2015-10-06 13:12 ` Chris Wilson
2015-10-01 11:18 ` [PATCH 4/5] drm/i915: Remove dead i915_gem_evict_everything() Chris Wilson
2015-10-01 11:18 ` [PATCH 5/5] drm/i915: Avoid GPU stalls from kswapd Chris Wilson
2015-10-06 13:01 ` Daniel Vetter
2015-10-06 13:18 ` Chris Wilson
2015-10-07 13:51 ` Daniel Vetter [this message]
2015-10-06 12:53 ` [PATCH 1/5] drm/i915: shrinker_control->nr_to_scan is now unsigned long Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007135158.GE3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox